Ticket #1311 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Pass by reference in IPropertyManager::setProperty(string, T)

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

The code for IPropertyManager::setProperty(const string&, const T) should accept the value by reference rather than by value. This will stop a potential truncation error which may be what is breaking polymorphism.

Change History

comment:1 Changed 10 years ago by Peter Peterson

  • Status changed from new to accepted
  • Owner set to Peter Peterson

comment:2 Changed 10 years ago by Peter Peterson

  • Status changed from accepted to closed
  • Resolution set to fixed

(In [4855]) Added that funny character to pass by reference. All the unit tests pass so it must be ok (wink). Fixes #1311.

comment:3 Changed 10 years ago by Nick Draper

  • Status changed from closed to verify

moved to verify status

comment:4 Changed 10 years ago by Nick Draper

Moved to verify state

comment:5 Changed 10 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:6 Changed 10 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2158

Note: See TracTickets for help on using tickets.