Ticket #1339 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

API::Axis is not using polymorphism effectively

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description

You are using a single class, Axis, to represent spectra number and some other double value, and using a flag and endless if checks to see how the class operates. Instead, you should have an AxisSpectra and AxisNumeric classes that inherit from Axis.

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

(In [4949]) Refs #1267 and #1339; an axis for EventWorkspace holds the workspace index -> spectrum # map. See ticket #1339 for my comments on odd design of Axis

comment:2 Changed 10 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Janik Zikovsky

comment:3 Changed 10 years ago by Janik Zikovsky

  • Status changed from assigned to accepted

comment:4 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to testing
  • Resolution set to fixed

This has already been fixed by Roman Tolchenov (refs #1347).

comment:5 Changed 10 years ago by Nick Draper

  • Status changed from testing to verify

Moved to verify state

comment:6 Changed 10 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:7 Changed 10 years ago by Peter Peterson

  • Status changed from verifying to closed

The last comment was right. #1347 does solve the issue in [5084].

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2186

Note: See TracTickets for help on using tickets.