Ticket #1348 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Use portable define statements in scons configuration

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: critical Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

According to ​SCons Crash Course rather than setting the cflags directly for defines, the portable way is to declare them using 

env.Append(CPPDEFINES=['BIG_ENDIAN'])

Change History

comment:1 Changed 10 years ago by Peter Peterson

  • Status changed from new to accepted
  • Owner set to Peter Peterson

comment:2 Changed 10 years ago by Peter Peterson

(In [5019]) Adding portable definitions declaration for boost date time class. Refs #1348 and #1267.

comment:3 Changed 10 years ago by Peter Peterson

(In [5022]) Redid all of the main defines using the environment rather than separate variables. Refs #1348.

comment:4 Changed 10 years ago by Peter Peterson

(In [5023]) Condensed all of the common nt checks into a single place to make reading the file easier. Refs #1348.

comment:5 Changed 10 years ago by Peter Peterson

(In [5024]) Trying to fix windows build issue. Refs #1348.

comment:6 Changed 10 years ago by Peter Peterson

  • Status changed from accepted to testing
  • Resolution set to fixed

The last commit fixed this.

comment:7 Changed 10 years ago by Nick Draper

  • Status changed from testing to verify

Moved to verify state

comment:8 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:9 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

The build servers work and my linux build doesn't have any issues therefore I'm marking this as passed.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2195

Note: See TracTickets for help on using tickets.