Ticket #1358 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Make AlignDetectors work with EventWorkspace

Reported by: Peter Peterson Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 24
Component: Keywords: event
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Rather than letting the histogram representation make the magic happen, AlignDetectors will be modified to work with EventWorkspace

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Owner changed from Peter Peterson to Janik Zikovsky
  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

(In [5300]) Refs #1358: start of some code to AlignDetectors with an event workspace

comment:3 Changed 10 years ago by Peter Peterson

(In [5341]) Checkpointing progress so others can start working on it. Refs #1358.

comment:4 Changed 10 years ago by Janik Zikovsky

(In [5441]) Refs #1358: Had accidentally enabled a not-finished unit-test; re-disabling.

comment:5 Changed 10 years ago by Janik Zikovsky

(In [5442]) Refs #1358: removed a bad line.

comment:6 Changed 10 years ago by Peter Peterson

(In [5458]) Checkpointing a function that calculates the tof to d factor. Refs #1358.

comment:7 Changed 10 years ago by Peter Peterson

(In [5462]) Migrated existing calculation of tof to d factor to use the new encapsulated function. Refs #1358.

comment:8 Changed 10 years ago by Martyn Gigg

(In [5468]) Fix a crash on Windows from dereferencing a past-the-end iterator. Re #1358.

comment:9 Changed 10 years ago by Janik Zikovsky

(In [5469]) Refs #1358: Methods in EventList to convert units.

comment:10 Changed 10 years ago by Janik Zikovsky

(In [5470]) Refs #1358: first test of AlignDetectors for event workspace was enabled; test is not complete yet, but passes.

comment:11 Changed 10 years ago by Janik Zikovsky

(In [5471]) Refs #1358: test runs in the case of having the same output WS.

comment:12 Changed 10 years ago by Peter Peterson

(In [5472]) Removed commented out code. Refs #1358.

comment:13 Changed 10 years ago by Peter Peterson

(In [5474]) Renamed function in eventlist since it is more generic than just to d-spacing. Refs #1358.

comment:14 Changed 10 years ago by Martyn Gigg

(In [5481]) Fix for index out-of-vector bounds that Windows is far less tolerant about. Re #1358

comment:15 Changed 10 years ago by Peter Peterson

(In [5484]) Modifed how the conversion factor is calculated so if an offset is missing it is assumed to be zero. Refs #1358.

comment:16 Changed 10 years ago by Peter Peterson

(In [5488]) Made changes to give more functionality for tof conversions to people playing with events. Refs #1358.

comment:17 Changed 10 years ago by Peter Peterson

(In [5522]) Looks like the work is done but the calibration file I was using is all wrong. Refs #1358.

comment:18 Changed 10 years ago by Peter Peterson

(In [5525]) Adding test data for PG3. Refs #1358.

comment:19 Changed 10 years ago by Janik Zikovsky

(In [5569]) Refs #1358; diabled EventWorkspace-related tests of AlignDetectors.

comment:20 Changed 10 years ago by Peter Peterson

(In [5593]) Updating calibration file. Refs #1357 and #1358.

comment:21 Changed 10 years ago by Peter Peterson

(In [5630]) Put a line back in to copy the geometry and spectrum map over. Refs #1358.

comment:22 Changed 10 years ago by Janik Zikovsky

(In [5636]) Refs #1358: Make AlignDetectors copy an event workspace correctly; this seems to work, which means the ticket is almost closable.

comment:23 Changed 10 years ago by Janik Zikovsky

(In [5639]) Refs #1358: AlignDetectors parallelized for EventWorkspace

comment:24 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify

comment:25 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to reopened

comment:26 Changed 10 years ago by Janik Zikovsky

(In [5758]) Refs #1358: Refactored align detectors to make code reusable outside of the algorithm

comment:27 Changed 10 years ago by Janik Zikovsky

(In [5760]) Refs #1358: Moved align detectors to the Algorithms namespace and directory.

comment:28 Changed 10 years ago by Janik Zikovsky

(In [5763]) Refs #1358: I put the DLLExport in the wrong spot.

comment:29 Changed 10 years ago by Janik Zikovsky

(In [5765]) Refs #1358: reverting a change that caused test to fail.

comment:30 Changed 10 years ago by Janik Zikovsky

(In [5768]) Refs #1358: Fixed a few legacy references to DataHandling in AlignDetectors

comment:31 Changed 10 years ago by Janik Zikovsky

(In [5769]) Refs #1358: Fix segfault when calling AlignDetectors destructor.

comment:32 Changed 10 years ago by Janik Zikovsky

  • Status changed from reopened to accepted

comment:33 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify

comment:34 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to reopened

AlignDetectors looks off by a factor of x2.0 for PG3

comment:35 Changed 10 years ago by Peter Peterson

(In [5807]) New identity calibration file for powgen. Refs #1358.

comment:36 Changed 10 years ago by Janik Zikovsky

  • Status changed from reopened to accepted

comment:37 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify

Problem with PG3 was the calibration file, not the algorithm, so re-re-resolving it.

comment:38 Changed 10 years ago by Nick Draper

  • Resolution set to fixed

fill in missing resolution

comment:39 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:40 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

Verified in [5941]

Confirmed that running AlignDetectors on an EventWorkspace produces another EventWorkspace and not a Workspace2D.

comment:41 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2205

Note: See TracTickets for help on using tickets.