Ticket #1362 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Create a common class for the excitations GUI

Reported by: Martyn Gigg Owned by: Michael Whitty
Priority: major Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Create a ConvertToEnergy class that can serve as the base class for the Direct and Indirect interfaces such that the only interface that apears to Mantid(Plot) is one called ConvertToEnergy.

It will just handle switching the view between what is appropriate for the selected instrument.

Change History

comment:1 Changed 10 years ago by Martyn Gigg

  • Owner set to Michael Whitty
  • Status changed from new to assigned

comment:2 Changed 10 years ago by Michael Whitty

(In [5059]) adding (bare) ui/qt files for eventual Homer replacement. re #1362

comment:3 Changed 10 years ago by Michael Whitty

  • Status changed from assigned to accepted

comment:4 Changed 10 years ago by Martyn Gigg

(In [5071]) Added absolute normalisation to Direct instrument convert to energy scripts and updated the GUI to use them. Homer has been removed as the top-level interface and the ConvertToEnergy interface now sets up the GUI for Direct mode. Also fixed a couple of warnings in GUI classes. Re #1045 #1362

comment:5 Changed 10 years ago by Martyn Gigg

(In [5086]) Implemented an alias mechanism for the custom interfaces so that upon renaming them a link to the old name can still be kept. Re #1362

comment:6 Changed 10 years ago by Martyn Gigg

(In [5090]) Fix MantidPlot build. Windows seem to let the accidental circular dependency through. In order to be able to delete the temporary interface that has been created an initialized flag has been added to the SANSRunWindow so that its destructor does nothing if it hasn't been setup. Re #1362

comment:7 Changed 10 years ago by Martyn Gigg

(In [5091]) Didn't need the extra variable, it should have used the already implemented isInitialized() function. Re #1362

comment:8 Changed 10 years ago by Martyn Gigg

(In [5097]) Disable MantidQt alias mechansim temporarily as it causes problems with Mantid when the libraries are in the same directory as the plugins but are run outside of MantidPlot. Re #1362

comment:9 Changed 10 years ago by Martyn Gigg

(In [5101]) Reimplemented name & alias functions as static so that an object doesn't need to be of that type as this caused problems when the libraries were loaded outside of MantidPlot. Re #1362

comment:10 Changed 10 years ago by Martyn Gigg

(In [5102]) Missed a file on last check in. Re #1362

comment:11 Changed 10 years ago by Michael Whitty

(In [5182]) adjustments to ConvertToEnergy class moving applicable setup steps out of Homer. Also, added bar "Indirect" class for inelastic instruments. ConvertToEnergy class now switches to relevant interface based on instrument selection, rather than just going straight to Homer. re #1362

comment:12 Changed 10 years ago by Michael Whitty

(In [5183]) re #1362 - changes to instrument parameter files to enable selection of direct(homer)/indirect setup in ConverToEnergy MantidPlot interface.

comment:13 Changed 10 years ago by Martyn Gigg

(In [5184]) Correct a case issue causing the Linux MantidPlot build to fail. Re #1362

comment:14 Changed 10 years ago by Russell Taylor

(In [5187]) Fix test failure. The addition of an instrument parameter file for OSIRIS caused an unimportant test to fail (but the check-in didn't trigger a build so wasn't immediately apparent). Re #1362.

comment:15 Changed 10 years ago by Martyn Gigg

(In [5189]) Remove some warning messages from the UI compiler and removed the old interface file. Re #1362

comment:16 Changed 10 years ago by Martyn Gigg

(In [5194]) Change the name of an Python exposed component as it classed with something else which was uncovered by a system test failure. Re #1362

comment:17 Changed 10 years ago by Michael Whitty

(In [5307]) re #1362 - exposing getDistance() function to IComponent PythonAPI which has been missing for a while

comment:18 Changed 10 years ago by Michael Whitty

  • Status changed from accepted to verify

comment:19 Changed 10 years ago by Nick Draper

  • Resolution set to fixed

fill in missing resolution

comment:20 Changed 10 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:21 Changed 10 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2209

Note: See TracTickets for help on using tickets.