Ticket #1369 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Masking in the SANS interface to be displayed correctly

Reported by: Steve Williams Owned by: Steve Williams
Priority: major Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

After receiving the email below from stephen.king@…. I found that the masking specifications list on the SANS interface "Masking" tab weren't display correctly when "Display mask" was clicked.

Hi,

Attached are two SANS2D user files I’ve created which differ only in that one acts on the rear det and one on the front det.

In the one for the front det I’ve added an extra line to mask out horiz rows 144-159.  However, the view I get with ‘Display Mask’ from the Masking tab looks identical for both.

Is this just a QtiPlot display issue, or is there something deeper going on?

An example run I was looking to process was 920 from Cycle 09_2.


Steve

Change History

comment:1 Changed 10 years ago by Steve Williams

  • Status changed from new to accepted

Refactored the code grouping together information about the instrument and its detectors in one class. Made the code more intuitive by ensuring that the correct instrument is set before loading files.

This helped the problem above because ApplyMasking() had to be run twice, once for each detector, implying a list of detectors on each instrument exists. Running Python scripts as well as the GUI gave confusing results which confuse testing as well as eventually users.

comment:2 Changed 10 years ago by Steve Williams

(In [5175]) View masking in the SANS interface now respects per detector masking settings. Small SANS instrument and detector Python classes have been written. re #1369

comment:3 Changed 10 years ago by Steve Williams

(In [5196]) Fix the broken system test and two other SANS bugs re #1369

comment:4 Changed 10 years ago by Steve Williams

(In [5215]) Fix a SANS bug I created on my last check-in re #1369

comment:5 Changed 10 years ago by Steve Williams

  • Status changed from accepted to verify

BTW masking can be viewed in the "Masking" tab of the SANS interface

comment:6 Changed 10 years ago by Nick Draper

  • Resolution set to fixed

fill in missing resolution

comment:7 Changed 10 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:8 Changed 10 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2216

Note: See TracTickets for help on using tickets.