Ticket #1376 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Refactor Most Recently Used list in ManagedWorkspace2D and AbsManagedWorkspace2D

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 24
Component: Keywords:
Cc: pf9@… Blocked By:
Blocking: Tester: Peter Peterson

Description

... to enhance code reuse.

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

(In [5209]) Refs #1376: refactored MRUList out of the AbsManagedWorkspace2D class. Some const's added to CompressedWorkspace2D. Still need to clean up ManagedWorkspace2D

comment:3 Changed 10 years ago by Janik Zikovsky

I also de-templated AbsManagedWorkspace2D<int> - why use a template when a simple constructor argument does the job?

comment:4 Changed 10 years ago by Janik Zikovsky

(In [5210]) Refs #1376: Improved code reuse by removing duplicated code from ManagedWorkspace2D. Cleaned up comments of related files as well.

comment:5 Changed 10 years ago by Janik Zikovsky

(In [5214]) Refs #1376 - Moved MRUList to the Kernel namespace.

comment:6 Changed 10 years ago by Janik Zikovsky

(In [5224]) Refs #1359 and #1376. Implements a MRU for the EventWorkspace. Tracked down memory leak - memory usage seems constant in use in MantidPlot.

comment:7 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to testing
  • Resolution set to fixed

ManagedWorkspace2D seems to be using the MRUList just fine. All tests have passed.

comment:8 Changed 10 years ago by Nick Draper

  • Status changed from testing to verify

Moved to verify state

comment:9 Changed 10 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:10 Changed 10 years ago by Peter Peterson

  • Status changed from verifying to closed

This works.

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2223

Note: See TracTickets for help on using tickets.