Ticket #1399 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Harmonise widget usage in SANS

Reported by: Nick Draper Owned by: Steve Williams
Priority: major Milestone: Iteration 28
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: #2286 Tester: Nick Draper

Description

Adjust the interface to use the standard instrument and file load widgets

Change History

comment:1 Changed 10 years ago by Steve Williams

  • Status changed from new to accepted
  • Component set to Mantid
  • Milestone changed from Iteration 25 to Iteration 26

comment:2 Changed 10 years ago by Steve Williams

  • Component changed from Mantid to MantidPlot

The SANS group still need to manually specify a data search directory [which proceeds the system paths]. The file widgets must still accept the "add files" as well as raw files. Their syntax is:

My memory must be going, SANS2d add files are currently called e.g.

SANS2d00002502-add.nxs

With “–add” 

Richard

comment:3 Changed 10 years ago by Steve Williams

Todo: Remove the raw/nexus combination box. Replace the 9 existing run number entry edit boxes with RunFile widgets. Decide if the widgets need to be redisgned (without a browse button). To handle -add files perhaps it will work when "-add.raw" and "-add.nsx" extensions are added to the widget and the ISIS/SANS and LOQ extension lists.

comment:4 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:5 Changed 10 years ago by Steve Williams

(In [8814]) The ISIS SANS GUI now uses the Instrument selector re #1399

comment:6 Changed 10 years ago by Steve Williams

(In [8823]) Work-around to be reversed before February. ISIS SANS GUI can't display the instruments in the instrument selector yet as it depends on index numbers in the old combo box re #1399

comment:7 Changed 10 years ago by Steve Williams

(In [8854]) Remove magic numbers referring to the instrument combo from the SANS GUI code re #1399

comment:8 Changed 10 years ago by Nick Draper

  • Blocking 2286 added

comment:9 Changed 10 years ago by Steve Williams

(In [8952]) Case consistency with "Small Angle Scattering" in Facities.xml and the ISIS SANS GUI has a new wav loop widget! refs #1399 and #2212

comment:10 Changed 10 years ago by Steve Williams

(In [9138]) Fix ISIS SANS system test failure from using log files re #1399

comment:11 Changed 10 years ago by Steve Williams

(In [9339]) Correct problems with the run files widget and updating controls with info from user settings file re #1399

comment:12 Changed 10 years ago by Steve Williams

(In [9353]) Improve the way the run file widget displays re #1399

comment:13 Changed 10 years ago by Steve Williams

(In [9359]) Forgot to commit two files re #1399

comment:14 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:15 Changed 10 years ago by Steve Williams

(In [9494]) Fix broken system tests re #1399

comment:16 Changed 9 years ago by Steve Williams

(In [11086]) On the SANS GUI first page run widgets replace the boxes, I'm committing a large amount of code that I was close to losing re #1399

comment:17 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:18 Changed 9 years ago by Steve Williams

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [11104]) Re-implementing things that were in the file I lost fixes #1399

comment:19 Changed 9 years ago by Russell Taylor

  • Milestone changed from Iteration 29 to Iteration 28

comment:20 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:21 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

The current interface uses the standard instrument and file loader widgets that I've seen on other GUIs, so the request has been fulfilled.

comment:22 Changed 9 years ago by Steve Williams

  • Status changed from closed to reopened
  • Resolution fixed deleted

The user pointed out that "If you don’t specify direct beam run number for the can, it puts in the can transmission number". Which is wrong

comment:23 Changed 9 years ago by Steve Williams

  • Status changed from reopened to accepted

There needs to be good documentation on the first tab (including defaults, what the buttons do, etc.) here http://www.mantidproject.org/Using_the_SANS_GUI

comment:24 Changed 9 years ago by Steve Williams

(In [11609]) The ISIS SANS direct can default was getting filled in wrong. Kill the Matlab warning re #1399 re #2897

comment:25 Changed 9 years ago by Steve Williams

(In [11646]) Beam Finder needs to reset the centre position each iteration re #1399

comment:26 Changed 9 years ago by Steve Williams

(In [11655]) Beam Finder needs minuses as SANS see the detector from the other side re #1399

comment:27 Changed 9 years ago by Steve Williams

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:28 Changed 9 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester changed from Michael Reuter to Nick Draper

comment:29 Changed 9 years ago by Nick Draper

  • Status changed from verifying to closed

Not really tested as this squeezed through on the last iteration, and has now been in use for 2 months

comment:30 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2246

Note: See TracTickets for help on using tickets.