Ticket #1411 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Algorithms in vanillia python failing should generate a python exception

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

While working on a script to do a full reduction process I have noticed (by looking at the log statements) that one of the algorithms fails. This goes mostly unnoticed by the user since execution continues through the failure without any intervention by the script/user. This will create subtle bugs in the fact that most users won't look for Error in execution of algorithm AlignDetectors and think that the data is ok. What should happen is that the python API should turn this error into a thrown exception.

Change History

comment:1 Changed 10 years ago by Peter Peterson

  • Status changed from new to accepted
  • Owner set to Peter Peterson

comment:2 Changed 10 years ago by Peter Peterson

(In [5313]) Added an extra member variable rethrow to declare that algorithms just give up and rethrow exceptions during execution. Refs #1411.

comment:3 Changed 10 years ago by Peter Peterson

(In [5314]) Set the rethrows flag for things running in vanilla python. Refs #1411 and #Martin.

comment:4 Changed 10 years ago by Peter Peterson

  • Status changed from accepted to resolved

comment:5 Changed 10 years ago by Nick Draper

  • Status changed from resolved to verify

moved to verify

comment:6 Changed 10 years ago by Nick Draper

  • Resolution set to fixed

fill in missing resolution

comment:7 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:8 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

testing in #5905 - working. errors in algorithms are translated to Python exceptions.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2258

Note: See TracTickets for help on using tickets.