Ticket #1427 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Create 2 new "parameters.xml"s and remove all instrument specific data into classes

Reported by: Steve Williams Owned by: Steve Williams
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: martyn.gigg@… Blocked By:
Blocking: Tester: Martyn Gigg

Description

  1. Create SANS2D_Parameters.xml and LOQ_Parameters.xml files with instrument dependent numbers, including monitor numbers, which spectra numbers are in which detectors and how this varies between run numbers, filename zero padding, defaults (transmission wavelengths for normalisation, monitor number selection, sample thinkness, etc.)
  2. Move loading and holding these data from SANSReduction.py into an instrument class.


Williams time estimate 1 day

Change History

comment:1 Changed 10 years ago by Steve Williams

(In [5387]) Removing bad comments from SANSReduction.py re #1427

comment:2 Changed 10 years ago by Steve Williams

(In [5434]) Extends the SANS Instrument class and there are now parameter files for LOQ and SANS2D which have removed some instrument specific constants from SANSReduction.py, although more remain re #1427

comment:3 Changed 10 years ago by Steve Williams

(In [5435]) System test fix for change for the parameter map mis-match re #1427

comment:4 Changed 10 years ago by Steve Williams

(In [5445]) Fix broken system tests -two small errors in the SANS scripts re #1427

comment:5 Changed 10 years ago by Steve Williams

(In [5463]) System test fix for SANS instrument parameter files causing a parameter map mis-match with existing test data re #1427

comment:6 Changed 10 years ago by Steve Williams

(In [5492]) The SANS instrument parameter files and the SANS Python Instrument class contain everything they need re #1427

comment:7 Changed 10 years ago by Steve Williams

(In [5499]) Fix SANS system test by updating the parameter map in the comparison file re #1427

comment:8 Changed 10 years ago by Steve Williams

  • Status changed from new to accepted

comment:9 Changed 10 years ago by Martyn Gigg

M Gigg time estimate: 0.5 days

comment:10 Changed 10 years ago by Steve Williams

  • Status changed from accepted to verify

Took 2 days of effort to complete

comment:11 Changed 10 years ago by Nick Draper

  • Resolution set to fixed

fill in missing resolution

comment:12 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:13 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

Confirmed that files exists and contain appropriate data. Verified that the scripts now use these values and not those stored in the scripts themselves.

Verified in version #5882

comment:14 Changed 10 years ago by Steve Williams

  • Priority changed from critical to major
  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Milestone changed from Iteration 24 to Unassigned

comment:15 Changed 10 years ago by Steve Williams

  • Status changed from reopened to accepted

comment:16 Changed 10 years ago by Steve Williams

(In [6073]) Fix broken system tests (due to a small change to a parameter file) re #1427

comment:17 Changed 10 years ago by Steve Williams

(In [6076]) A new system test doesn't yet work, remove it re #1427

comment:18 Changed 10 years ago by Steve Williams

(In [6085]) Fix broken system test re #1427

comment:19 Changed 10 years ago by Steve Williams

(In [6149]) Fix SANS GUI bug re #1427

comment:20 Changed 10 years ago by Steve Williams

(In [6214]) Fix SANS GUI bug re #1427

comment:21 Changed 10 years ago by Steve Williams

  • Status changed from accepted to verify
  • Resolution set to fixed
  • Component set to Mantid

comment:22 Changed 10 years ago by Nick Draper

  • Milestone changed from Unassigned to Iteration 25

comment:23 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying

comment:24 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

Verified files exist and the instument objects defined in SANSInsts.py module work as advertised.

comment:25 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2274

Note: See TracTickets for help on using tickets.