Make EventList not hold copies of histogrammed data - keep that in the MRU list instead.

[Janik Zikovsky]

(suggested by Russell):

The other is that when reading from data stored in a cow_ptr (MantidVecPtr) you can use the (const) dereference operator rather than the access() method (which is non-const and can lead to the vector being copied - which I suppose would explain the the problems with multi-threading, though it should be protected).

The other thing I'd like to sort out is the copying of the data that has to take place in this part (when you fill local vectors and then use assign to copy the data into the workspace vectors). This is required because of line 443 in EventList.cpp. For a histogram workspace Y should always be one less than X in size, so this fails if you pass the pre-sized vector in. I tried just changing this line but that broke other things in the tests, and I'm guessing that line is really testing whether the vectors have already been filled. Actually, this ties into a bigger thing that I don't believe that EventList should be holding vectors at all now that the most-recently-used list is implemented. There should just be methods that can fill vectors to which it is passed references. These vectors should already have the correct size (though this can be checked if desired).

Russell

[Janik Zikovsky]

(In [5459]) Refs #1441: EventList no longer has a cache of histogrammed data.

[Janik Zikovsky]

(In [5464]) Refs #1441: fixed SimpleRebinTest

[Janik Zikovsky]

This fix looks like it improved the way memory is returned when rebinning the event workspace. Rebinning to a small histogram returns the memory.

[Nick Draper]

moved to verify

[Nick Draper]

fill in missing resolution

[Russell Taylor]

Yep, data histograms are gone from EventList. Just the required X vector left.

[Stuart Campbell]

This ticket has been transferred to github issue ​2288