Ticket #1455 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Clean up some warnings when building qtiplot

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: pf9@… Blocked By:
Blocking: Tester: Roman Tolchenov

Description


Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

(In [5587]) Refs #1455: on Linux, at least, qtiplot build raises many many warnings when a function returns a const int; changed Algorithm's version() function to return just an int. These raise 'type qualifiers ignored on function return type' because the const on the return value is superfluous, according to: ​http://stackoverflow.com/questions/1134237/pedantic-gcc-warning-type-qualifiers-on-function-return-type

comment:3 Changed 10 years ago by Janik Zikovsky

(In [5588]) Refs #1455: touching qtiplot to force a rebuild

comment:4 Changed 10 years ago by Janik Zikovsky

(In [5589]) Refs #1455: fixing build errors by modifying the Version() function of the algorithms in UserAlgorithms and ICat

comment:5 Changed 10 years ago by Janik Zikovsky

(In [5592]) Refs #1455: removed another const modifier to a function return value (const bool).

comment:6 Changed 10 years ago by Janik Zikovsky

(In [5594]) Refs #1455: more const return types removed.

comment:7 Changed 10 years ago by Janik Zikovsky

  • Milestone changed from Iteration 24 to Iteration 25

comment:8 Changed 10 years ago by Janik Zikovsky

(In [6038]) Refs #1455. Removed several hundred warnings in building qtiplot caused by pixmaps.h. Now, uses the getQPixmap() function to retrieve an XPM pixmap from a central function.

comment:9 Changed 10 years ago by Janik Zikovsky

(In [6039]) Refs #1455: forgot to add the pixmaps.cpp file, also a couple fewer warnings.

comment:10 Changed 10 years ago by Janik Zikovsky

(In [6040]) Refs #1455: more warnings reduced; also fix compiler error under windows, I hope.

comment:11 Changed 10 years ago by Janik Zikovsky

(In [6041]) Refs #1455: more eliminated warnings.

comment:12 Changed 10 years ago by Janik Zikovsky

(In [6060]) Refs #1455: fixed missing _xpm images.

comment:13 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed
  • Component set to Mantid

comment:14 Changed 10 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:15 Changed 10 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2302

Note: See TracTickets for help on using tickets.