Ticket #1462 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Give LoadSpec the power to load ascii files with multi spectrum in it

Reported by: Jean Bilheux Owned by: Michael Reuter
Priority: minor Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Peterson

Description


Change History

comment:1 Changed 10 years ago by Jean Bilheux

  • Status changed from new to closed
  • Resolution set to fixed

(In [5642]) Modified Code to allow the code to be able to read simple and multi ascii files produced by the SNS data reduction. This fixed #1462

comment:2 Changed 10 years ago by Nick Draper

  • Status changed from closed to verify

moved to verify

comment:3 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:4 Changed 10 years ago by Janik Zikovsky

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Steps for a crash:

  • I tried LoadSpec from the GUI MantidPlot
  • Filename: Test/Data/AsciiExample.txt
  • Any workspace name,
  • And I got a seg fault when I click OK.

I got segfaults on other text files - there should be some validation to help prevent segfaults.

Also, there should be a test for the algorithm, I couldn't find one.

comment:5 Changed 10 years ago by Jean Bilheux

  • Owner set to Jean Bilheux
  • Status changed from reopened to accepted

comment:6 Changed 10 years ago by Jean Bilheux

  • Milestone changed from Iteration 24 to Iteration 25

comment:7 Changed 10 years ago by Jean Bilheux

(In [5923]) Hide LoadSpec from current iteration. This refs #1462

comment:8 Changed 10 years ago by Jean Bilheux

(In [5998]) Program does not crash anymore when input format is wrong. This refs #1462

comment:9 Changed 10 years ago by Jean Bilheux

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:10 Changed 10 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Component set to Mantid
  • Tester changed from Janik Zikovsky to Peter Peterson

comment:11 Changed 10 years ago by Peter Peterson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

For the allowed units "MomemtumTransfer" (misspelled) crashed Mantid. The correct spelling "MomentumTransfer" works fine. Once this is fixed the ticket can be closed.

comment:12 Changed 10 years ago by Michael Reuter

  • Owner changed from Jean Bilheux to Michael Reuter
  • Status changed from reopened to accepted

comment:13 Changed 10 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [7202]) Removed misspelled unit as it is unnecessary. This fixes #1462.

comment:14 Changed 10 years ago by Peter Peterson

  • Status changed from verify to verifying

comment:15 Changed 10 years ago by Peter Peterson

  • Status changed from verifying to closed

It works now.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2309

Note: See TracTickets for help on using tickets.