Ticket #1466 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Calculate parameters that are not supplied in LoadEventPreNeXus

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

This ticket covers a couple of things

  1. Remove the PeriodList parameter
  2. If the pulseid file is not specified guess where it my be and try to open it.
  3. Verify that the pulseid file is a valid type
  4. Remove the instrument file from the list of parameters and get it via a new bit of code in kernel that returns the file path from the instrument name.
  5. Get the mapping filename from the instrument parameter file and find it if it is not specified by the user.
  6. Get whether or not to pad empty pixels from the instrument parameter file.

Change History

comment:1 Changed 10 years ago by Peter Peterson

  • Owner set to Peter Peterson
  • Status changed from new to accepted

comment:2 Changed 10 years ago by Peter Peterson

(In [5601]) Removed the period list from the parameters since it will never be implemented. Refs #1466.

comment:3 Changed 10 years ago by Peter Peterson

(In [5612]) Exposing simple static function to the outside. Refs #1466.

comment:4 Changed 10 years ago by Peter Peterson

(In [5618]) Determine the name of the pulseid file if it is not specified. Refs #1466.

comment:5 Changed 10 years ago by Peter Peterson

(In [5619]) Check that the created pulseid file exists. Refs #1466.

comment:6 Changed 10 years ago by Peter Peterson

(In [5620]) Automatically fetch the instrument geometry based on instrument name gleaned from the event filename. Refs #1466.

comment:7 Changed 10 years ago by Peter Peterson

(In [5631]) Slightly better formatting on log statements and moved when the mapping file is loaded. Refs #1466.

comment:8 Changed 10 years ago by Peter Peterson

(In [5644]) Corrected type of mapping file name. Refs #1466.

comment:9 Changed 10 years ago by Peter Peterson

(In [5661]) Allow failing to load pulseid to not stop getting the rest of the data in. Refs #1466.

comment:10 Changed 10 years ago by Martyn Gigg

(In [5671]) Removed debugging code that was causing a test to report as a failure. Re #1466

comment:11 Changed 10 years ago by Peter Peterson

  • Status changed from accepted to closed
  • Resolution set to fixed

(In [5673]) Track down the mapping file based on a value in the parameter file. Closes #1466.

comment:12 Changed 10 years ago by Peter Peterson

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:13 Changed 10 years ago by Peter Peterson

  • Status changed from reopened to accepted

The last commit broke one of the unit tests.

comment:14 Changed 10 years ago by Peter Peterson

  • Status changed from accepted to closed
  • Resolution set to fixed

(In [5677]) Fixed bug when looking for the mapping file in the archive area. Fixes #1466.

comment:15 Changed 10 years ago by Nick Draper

  • Status changed from closed to verify

moved to verify

comment:16 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:17 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

Verified [5962].

All items work as advertised with the exception of the pad-empty pixels parameter. This doesn't exist in the parameter file only as an option.

I'm closing the ticket since this small thing doesn't seem to warrant failing it.

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2313

Note: See TracTickets for help on using tickets.