Ticket #1490 (closed: wontfix)
Make ConvertUnits handle EventWorkspaces
Reported by: | Michael Reuter | Owned by: | Michael Reuter |
---|---|---|---|
Priority: | major | Milestone: | Iteration 24 |
Component: | Keywords: | ||
Cc: | Blocked By: | ||
Blocking: | Tester: | Janik Zikovsky |
Description
The ConvertUnits algorithm should be able to handle converting EventWorkspaces.
Change History
comment:5 Changed 10 years ago by Michael Reuter
- Status changed from new to accepted
Forgot accept ticket.
comment:6 Changed 10 years ago by Michael Reuter
- Status changed from accepted to verify
The requested work has been completed.
comment:11 Changed 10 years ago by Peter Peterson
comment:12 Changed 10 years ago by Peter Peterson
comment:13 Changed 10 years ago by Peter Peterson
comment:16 Changed 10 years ago by Janik Zikovsky
- Status changed from verify to verifying
- Tester set to Janik Zikovsky
comment:17 Changed 10 years ago by Janik Zikovsky
- Status changed from verifying to reopened
- Resolution fixed deleted
Works great converting back and forth between TOF, dSpacing, wavelength.
I tried taking some PG3 data (run 732) and converting from TOF to energy (probably doesn't make sense, but I wasn't sure how to try that conversion); I used Indirect and 25 meV for EFixed. The conversion seems to work, it runs, but the final bin X boundary is always infinity; it doesn't matter what the bins are in the input or what EFixed is, the last X boundary is always infinity.
comment:19 Changed 10 years ago by Michael Reuter
- Status changed from accepted to verify
- Resolution set to wontfix
Yes, this is the expected behavior for TOF->E or TOF->deltaE for 1/0. So, instead of the code throwing an exception, the Kernel::Units class puts in a "sensible" number for division by zero. This will make the first bin infinity and the reverse should make it the last bin, but still infinity. I can't think of a better way to handle it unless the event reader blocks the use of zero as the initial lower bin boundary, but I don't like that either. This is just a "feature" of inverse conversions (like E and Q) with 0.
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 2338
(In [5728]) Reorganize test in preparation for event workspace testing. This refs #1490.