Ticket #1497 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

BinFinder: give bin parameters and an X value, and it finds the bin index corresponding.

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: critical Milestone: Iteration 24
Component: Keywords:
Cc: pf9@… Blocked By:
Blocking: Tester: Martyn Gigg

Description

Needs to work for log and/or linear binning. Should be a class that is set up once, and called many times.

Needed by GhostCorrection

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

(In [5740]) Refs #1497: BinFinder class added in Kernel; for quick binning of events. Tests are disabled right now because I was not able to build them under Windows.

comment:3 Changed 10 years ago by Janik Zikovsky

(In [5741]) Refs #1497: changed abs() to fabs() to fix build error.

comment:4 Changed 10 years ago by Janik Zikovsky

(In [5755]) Refs #1497: fixed BinFinder, tests now all pass.

comment:5 Changed 10 years ago by Janik Zikovsky

(In [5761]) Refs #1497: last bin index function.

comment:6 Changed 10 years ago by Janik Zikovsky

(In [5775]) Refs #1497: Adjusted the BinFinder so that the last bin size matches the VectorHelper's result if it is so small that the vector helper removes it.

comment:7 Changed 10 years ago by Michael Whitty

(In [5824]) re #1497 - added BinFinder to Visual Studio project file.

comment:8 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify

comment:9 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:10 Changed 10 years ago by Nick Draper

  • Resolution set to fixed

fill in missing resolution

comment:11 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

Verified working in #5913. Tested with stand alone main routine.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2344

Note: See TracTickets for help on using tickets.