3 BUGS: with group workspaces

[Janik Zikovsky]

Bug 1:

• Load two workspaces, cncs1, cncs2
• Group them to NewGroup
• Rebin NewGroup to NewGroup
• workspace names become NewGroup_1 and NewGroup_2: it would be nice if they kept the original name

Bug 2, keep going:

• Now try to load into workspace cncs1 again. Loading is successful, but cncs1 is nowhere to be seen.

Bug 3:

• Load two workspaces, cncs1, cncs2
• Group them to NewGroup
• MaskDetectors on NewGroup
• Group is now empty.

[Russell Taylor]

And another one....

Bug 4:

• Running ConjoinWorkspaces (inherits from PairedGroupAlgorithm) seems to require that the members of the group are called ParentName_1, _2, _3 etc. At least the unit test failed until this was the case. This must be up in the generic processing somewhere.

[Sofia Antony]

(In [6998]) re#1527 - fix for 3 workspace group bugs. 1 and 3 fixed.2 is not a bug - in this case the workspace is a member workspace which is part of already loaded group workspace.Expand the group workspace to see the updated member workspace. Now if an algorithm takes 1) i/p and o/p group workspaces are of different names and the input group members are of similar names,then the o/p group workspace members are named o/p group workspace name appended with "-" and period number. example.i/p group workspace is "InputGroup" with two members "InputGroup_1","InputGroup_2" and o/p group workspace is "OutputGroup" the members of "outputGroup" will be "OutputGroup_1","OutputGroup_2". 2) i/p and o/p group workspace of same names, the o/p group workspace member is named the same name of the corresponding i/p group member workspace. example i/p group workspace is "Group" with two members"group_1","group_2" and o/p workspace name is same as i/p,then the o/p group members are "group_1","group_2" 3)i/p and o/p group workspaces of different names and i/p members are of different names then the o/p group workspace members are named as below inputmemberwsname_outgroupworkspacename example i/p group workspace "Group" with two members "evs","csp" and o/p group workspace is "NewGroup",then the o/p group workspace members are "evs_NewGroup","csp_NewGroup"

[Sofia Antony]

(In [6999]) re#1527 - fix for some build warnings

[Sofia Antony]

(In [7072]) re#1527 - PairedGroupAlgorithm changed to rename the o/p group members if i/p and o/p groups are of same names or diff.names.

[Sofia Antony]

(In [7106]) re#1527 - error messages added to PairedGroupAlgorithm when the member workspace not exists in ADS .

[Sofia Antony]

Bug 4 is fixed now.But Conjoinworkspaces is not working when one of the inputs is a group workspace and the second input is a single workspace.Also it's not functioning properly when we join two group workspaces with member workspaces of overlapping spectrum numbers though this prints error message. a new ticket will be created against this in the next iteration.

[Nick Draper]

Tested on 1.1.7148

Bug 1: Fixed Bug 2: No longer an issues once bug 1 is fixed, overwriting is expected behaviour Bug 3: fixed Bug 4: Spawned new ticket #1809

[Stuart Campbell]

This ticket has been transferred to github issue ​2374