Ticket #1530 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

ICat Basic search interface: add validator for run start and end numbers

Reported by: Sofia Antony Owned by: Sofia Antony
Priority: minor Milestone: Iteration 24
Component: Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description


Change History

comment:1 Changed 10 years ago by Sofia Antony

(In [5921]) re#1530 - validators for start and end run numbers are added.

comment:2 Changed 10 years ago by Sofia Antony

  • Status changed from new to accepted

comment:3 Changed 10 years ago by Sofia Antony

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:5 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

in [5943] a validator does indeed exist preventing the second run# entered being lower than the first

comment:6 Changed 10 years ago by Michael Whitty

however, the message is only passed to the "Results Log" pane, invalid input is not highlighted on the dialog and if user isn't paying attention to results pane or doesn't have it open, there would be nothing to tell them that the process hasn't (or isn't in the process of) running, and they may believe that the run button is merely unresponsive. I'd suggest either a popup (the MantidCustomInterface class provides showInformationBox function that serves this purpose well), or some sort of highlighting of invalid input such as exists in other interfaces.

comment:7 Changed 10 years ago by Michael Whitty

two new tickets #1550 and #1551 created to address issues noted above

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2377

Note: See TracTickets for help on using tickets.