Ticket #1555 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Speed up ConjoinWorkspaces unit test - it's really slow

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: trivial Milestone: Release 2.1
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

This unit test is taking over 30s on my Windows PC. Admittedly this is in debug mode and I can't easily check the release speed, but it needs to be more that 10x faster. It's using a setUp method. I think this is run before every test, and it loads all the data used by all the tests so a lot of redundant work is going on.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Owner set to Russell Taylor
  • Status changed from new to assigned

comment:2 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:3 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:7 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:8 Changed 9 years ago by Russell Taylor

  • Status changed from assigned to accepted
  • Component set to Mantid

comment:9 Changed 9 years ago by Russell Taylor

Speed up ConjoinWorkspacesTest. Re #1555.

Turns out it was only noticeably slow in debug on Windows (probably the Poco XML business), but this will help by cutting down on the data loading.

Changeset: 206e1d11c979982b411bc7cb6c48b269465119ec

comment:10 Changed 9 years ago by Russell Taylor

  • Priority changed from minor to trivial
  • Status changed from accepted to verify
  • Resolution set to fixed

The ORNL windows build (which is in release mode) got noticeably faster: 

History for ConjoinWorkspacesTest
Build   	         Duration   	Fail   	Skip   	Total   
ornl_windows7 #4648 	 0.4 sec	0	0	6
ornl_windows7 #4647 	 1.2 sec	0	0	7

comment:11 Changed 9 years ago by Russell Taylor

Speed up ConjoinWorkspacesTest. Re #1555.

Turns out it was only noticeably slow in debug on Windows (probably the Poco XML business), but this will help by cutting down on the data loading.

Changeset: 206e1d11c979982b411bc7cb6c48b269465119ec

comment:12 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:13 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

Verified speed up and test still functions correctly.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2402

Note: See TracTickets for help on using tickets.