Catch exceptions by reference

[Michael Reuter]

Catching exceptions by reference is good programming practice (see Item 13, More Effective C++ by Scott Meyers). It will also quiet those annoying warnings from Eclipse.

[Nick Draper]

Please also send out a message to Mantid-developers@… reminding everyone of best practice

Examples in

• API\MatrixWorkspace.cpp
• Geometry\Rendering\OCGeometryGenerator.cpp
• DataHandling\SaveCanSAS1d.cpp
• DataHandling\MaskDetectors.cpp
• DataHandling\LoadSpec.cpp
• DataHandling\LoadSNSSpec.cpp
• DataHandling\DetectorInfo.cpp
• DataHandling\LoadAscii.cpp
• DataHandling\GroupDetectors2.cpp
• Algorithms\Unwarp.cpp
• Algorithms\SolidAngle.cpp
• Algorithms\SofQW.cpp
• Algorithms\Regroup.cpp
• Algorithms\Qxy.cpp
• Algorithms\MedianDetectorTest.cpp
• Algorithms\InputWSDetectorInfo.cpp
• Algorithms\HRPDSlabCanAbsorption.cpp
• Algorithms\GetDetectorOffsets.cpp
• Algorithms\FlatBackground.cpp
• Algorithms\FindPeaks.cpp
• Algorithms\DetectorEfficiencyVariation.cpp
• Algorithms\ConvertUnits.cpp
• Algorithms\ChangeBinOffset.cpp
• Algorithms\AbsorptionCorrection.cpp
• Algorithms\AlignDetectors.cpp
• Algorithms\ConvertSpectrumAxis.cpp
• Nexus\LoadNexusProcessed.cpp
• Nexus\LoadISISNexus2.cpp
• CurveFitting\BoundaryConstraint

[Michael Reuter]

(In [7225]) Fixing exception catching in NeXus package. This refs #1571.

[Michael Reuter]

(In [7226]) Fixing exception catching in API package. This refs #1571.

[Michael Reuter]

(In [7227]) Fixing exception catching in DataHandling package. This refs #1571.

[Michael Reuter]

(In [7228]) Fixing exception catching in Algorithms package. This refs #1571.

[Michael Reuter]

All complaints fixed.

[Janik Zikovsky]

(In [8146]) Refs #1571: A few exceptions were not caught by reference.

[Stuart Campbell]

This ticket has been transferred to github issue ​2418