Ticket #1576 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Instrument Definition File Geometry roty rotates in wrong direction

Reported by: Vickie Lynch Owned by: Anders Markvardsen
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

When I use rot to rotate the detector around the y axis in the location element of the instrument definition file (rot="60.0" axis-x="0" axis-y="1" axis-z="0"), the detector is rotated correctly. When I try to use roty to do the same rotation, it rotates in the opposite direction.

<parameter name="roty">

<value val="60.0"/>

</parameter>

Change History

comment:1 Changed 10 years ago by Russell Taylor

  • Owner set to Anders Markvardsen
  • Status changed from new to assigned

comment:2 Changed 10 years ago by Anders Markvardsen

  • Status changed from assigned to accepted

comment:3 Changed 10 years ago by Anders Markvardsen

(In [6098]) Removed call to populateInstrumentParameters() in LoadEmptyInstrument since LoadEmptyInstrument calls LoadInstrument which calls populateInstrumentParameters(). Since roty "adjust" rather than set rotation calling populateInstrumentParameters() say twice causes roty to be applied twice. re #1576

comment:4 Changed 10 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

Vickie gave the green light that parameter rotation now appears to work

comment:5 Changed 10 years ago by Michael Whitty

(In [6109]) adjustment so that instrument parameters are still loaded even if the base instrument already exists in the data service, also adding LoadSNSSpec to the vcproj file - re #1576

comment:6 Changed 10 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Component set to Mantid
  • Tester set to Roman Tolchenov

comment:7 Changed 10 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2423

Note: See TracTickets for help on using tickets.