Ticket #158 (closed: fixed)
Memory is not released after Removing workspaces in QTIPlot
Reported by: | Nick Draper | Owned by: | Matt Clarke |
---|---|---|---|
Priority: | critical | Milestone: | Iteration 9 |
Component: | Keywords: | ||
Cc: | Blocked By: | ||
Blocking: | Tester: | Martyn Gigg |
Description
If you use the Remove Wrokspace button in QTIPlot the memory utilisation does not decrease.
Something must be holding a reference to the workspace and keeping the shared pointer alive.
Change History
comment:1 Changed 12 years ago by Nick Draper
- Owner set to Matt Clarke
- Priority changed from major to critical
- type changed from enhancement to defect
comment:3 Changed 12 years ago by Matt Clarke
- Status changed from new to closed
- Resolution set to fixed
Fixed the underlying problem, which was the clear() command not being executed in Algorithm. There are probably some algorithms which hold shared ptrs to workspaces which will need to be adjusted so they no longer do so.
comment:4 Changed 6 years ago by Pete Peterson
Re #158. Added google analytics to doxygen.
Changeset: b4a02f8db5eaeb1ba4b981fa99cbc52293247b79
comment:5 Changed 6 years ago by Pete Peterson
- Status changed from closed to verify
This is being verified as pull request #186.
comment:6 Changed 6 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:7 Changed 6 years ago by Martyn Gigg
Building locally I can see that this is fine.
We have a problem on the build servers though. They are running v1.8.3 and it looks like there is a bug where it doesn't expand the path to the static files properly. See [here](http://builds.mantidproject.org/job/doxygen_develop/ws/build/doxygen/html/index.html/*view*/) and look at <link href="$relpath^doxygen.css" rel="stylesheet" type="text/css" />.
I think we'll have to upgrade the packages on the builders to at least doxygen v1.8.6
comment:8 Changed 6 years ago by Pete Peterson
@martyngigg unfortunately that is part of the html header that I got directly from doxygen. I have access to 1.8.6 and 1.6.1. Which build server is running 1.8.3?
comment:9 Changed 6 years ago by Martyn Gigg
It looks to be ornl-rhel6-builder3 that ran the job that produced the bad output.
comment:10 Changed 6 years ago by Pete Peterson
Generate the doxygen header on the fly
This requires a couple of new commands and a one-off python script to do the actual work. If only the doxygen header was version portable. Re #158
Changeset: 636dd20f3b7c2383b39ffb098be576bb4c31b5db
comment:11 Changed 6 years ago by Martyn Gigg
This looks fine now. The header appears on the broken doxygen version and my newer one that worked originally.
comment:12 Changed 6 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge pull request #186 from mantidproject/158/doxygen_tracking
Added google analytics to doxygen.
Full changeset: 9b584d56ed9b07809822c6a4fa7e0d180a978880
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 1006