Ticket #1582 (closed: fixed)
AlphaCalc muon algorithm
| Reported by: | Anders Markvardsen | Owned by: | Anders Markvardsen |
|---|---|---|---|
| Priority: | major | Milestone: | Iteration 25 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Whitty |
Description
Muon algorithm for calculating the detector efficiency between two groups of detectors
Properties:
Inputworkspace in ForwardSpectra in BackwardSpectra in Alpha out
As a first approximation calculate this by from first-good-bin sum forward and backward histograms and then estimate alpha to be the "sum of forward" / "sum of backward"
Change History
comment:4 Changed 10 years ago by Anders Markvardsen
- Status changed from new to accepted
- Component set to Mantid
comment:5 Changed 10 years ago by Anders Markvardsen
- Status changed from accepted to verify
- Resolution set to fixed
comment:6 Changed 10 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:7 Changed 10 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution fixed deleted
The code looks OK for the most part and does what is intended to do. However, the conditional check on the integration for the backward spectrum isn't as strict as the associated error log message implies. The conditional sumBackward < 0 should be changed to sumBackward <= 0 in order to comply with the less than or equal to zero condition to stop the possibility of getting nan or inf for alpha. I'm going to send this back to you since the fix is easy and stops a potential problem.
comment:9 Changed 10 years ago by Anders Markvardsen
- Status changed from reopened to accepted
Well spotted Michael for seeing this potential divide by zero error!:) (I only noticed that you had reopended this ticket this morning)
comment:10 Changed 10 years ago by Anders Markvardsen
- Status changed from accepted to verify
- Resolution set to fixed
comment:11 Changed 10 years ago by Michael Whitty
- Status changed from verify to verifying
- Tester changed from Michael Reuter to Michael Whitty
comment:12 Changed 10 years ago by Michael Whitty
- Status changed from verifying to closed
the equals sign is there. it built. it runs.
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 2429
(In [6476]) Added MuonAlphaCalc alg Few text updates of MuonAsymmetryCalc alg Deleted a block which I had commented out in a previous change made to ParameterMap.cpp re #1582.