Ticket #1598 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Nested <trans> and <rot> in IDF <location> element

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

Noticed a notaion inconsistency which is bound to cause someone swearing over Mantid at some point if not fixed.

Currently the following means

<location x="10" >

<rot val="90" >

<trans x="-8" />

</rot>

</location>

puts something at (x,y,z)=(2,0,0). Hence the inner most <trans> ignores its parent <rot val="90" >. Reading this, and to also make this notation consistent with the rest of the IDF notation, it would make more sense if the above resulted in something be located at (x,y,z)=(10,-8,0). (Note the <rot val="90" > causes the x-axis to rotated onto the y-axis).

Change History

comment:1 Changed 10 years ago by Anders Markvardsen

(In [6093]) Improved nested <trans> and <rot> handling in IDF <location> element.

Refs #1598.

comment:2 Changed 10 years ago by Anders Markvardsen

  • Status changed from new to accepted

Wiki updated

comment:3 Changed 10 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 10 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Component set to Mantid
  • Tester set to Roman Tolchenov

comment:5 Changed 10 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Checked using a mock IDF with a detector at location described in the ticket. It appears to be at the right place and rotated 90 degrees around the z axis

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2445

Note: See TracTickets for help on using tickets.