Ticket #1669 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Create "ElasticWindow" Algorithm

Reported by: Michael Whitty Owned by: Michael Whitty
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

To perform the task of Elwin in the indirectAnalysis UI and provide a simple front end to users.

Inputs: Workspace (units in Energy transfer/mev), time range start and end, optional background range start and end

Outputs: Two workspaces of intensity / q and intensity over q2

This will replace the current Elwin PythonAlgorithm, while also giving both outputs requested, and hopefully performing better

Change History

comment:1 Changed 10 years ago by Michael Whitty

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Michael Whitty

waiting on #1673

comment:3 Changed 10 years ago by Sofia Antony

(In [6838]) re #1669 - Created a new class ICat3Catalog to implement information catalog for ISIS. ICat algorithms changed to call the underlying API through ICatalog interface.

comment:4 Changed 10 years ago by Sofia Antony

(In [6841]) re #1669 - fix for Linux build failure

comment:5 Changed 10 years ago by Sofia Antony

(In [6844]) re #1669 - fix for Linux build failure

comment:6 Changed 10 years ago by Sofia Antony

(In [6846]) re #1669 - fix for Linux build failure

comment:7 Changed 10 years ago by Sofia Antony

(In [6847]) re #1669 - fix for build failure

comment:8 Changed 10 years ago by Sofia Antony

(In [6848]) re #1669 - fix for build failure

comment:9 Changed 10 years ago by Sofia Antony

(In [6863]) re #1669 -some minor changes

comment:10 Changed 10 years ago by Michael Whitty

changes by Sofia in [6838], [6841], [6844], [6846], [6847 , [6848] and [6863] relate to ticket #1699 not this one

comment:11 Changed 10 years ago by Michael Whitty

(In [6926]) re #1669 - ElasticWindow (formerly 'Elwin') algorithm for indirectAnalysis

comment:12 Changed 10 years ago by Michael Whitty

(In [6995]) refs #1673, refs #1669 - allow saving of workspaces with non-spectra axis, would previously cause algorithm to fail

comment:13 Changed 10 years ago by Michael Whitty

(In [6997]) re #1669 - changing python script to use ElasticWindow algorithm, removing "Elwin" python algorithm

comment:14 Changed 10 years ago by Michael Whitty

(In [7047]) re #1669 - changing order of parameters in ElasticWindow algorithm so that it makes slightly more sense

comment:15 Changed 10 years ago by Sofia Antony

(In [7101]) re#1669 - minor changes to ICat interface

comment:16 Changed 10 years ago by Michael Whitty

  • Status changed from accepted to verify
  • Resolution set to fixed

mark complete

comment:17 Changed 10 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:18 Changed 10 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

It looks like in the section where the background range is used that the range 1 integration values are not used to perform the integration step. Is it the intention of the algorithm that the background range and main integration range always be the same? If so, this could be handled by a check box instead of a second set of redundant parameters. Otherwise, the range 1 integration values need to be used in the background subtraction section.

comment:19 Changed 10 years ago by Michael Whitty

  • Status changed from reopened to verify
  • Resolution set to fixed

(In [7157]) fixes #1669 - fixing typo, thanks to MR for highlighting it to me.

comment:20 Changed 10 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:21 Changed 10 years ago by Michael Reuter

  • Status changed from verifying to closed

OK, now it looks like everything is in order with this algorithm.

comment:22 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2516

Note: See TracTickets for help on using tickets.