SaveSPE: should throw an error if it runs out of disk space

[Janik Zikovsky]

We ran SaveSPE for a while to a mount with no more space available; it created 0-length files rather than throw any useful error message.

[Nick Draper]

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

[Nick Draper]

Bulk move of tickets at the end of iteration 27

[Nick Draper]

Bulk move of tickets at the end of iteration 28

[Nick Draper]

Accepted and assigned tickets moved at iteration 29 code freeze

[Nick Draper]

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

[Nick Draper]

Moved to iteration 33 at iteration 32 code freeze

[Nick Draper]

Moved at end of release 2.1

[Nick Draper]

Moved at the end of release 2.2

[Nick Draper]

Moved to milestone 2.4

[Nick Draper]

Moved at the code freeze for release 2.4

[Nick Draper]

Moved to r2.6 at the end of r2.5

[Keith Brown]

Moved the bulk of exec to a new function in SaveSPE.

Created new macro to wrap fprintf so it throws an exception when it prints nothing, so that when the write fails i can catch the exception, close the file and delete it with the filename in scope. Refs #1671

Changeset: d5e5e8f0d846ed43d6c9f50cf85f3084b8785e8e

[Keith Brown]

Added file remove functionality

File is now removed if the function throws as the file wasn't written properly

Refs #1671

Changeset: 2741e79b66e332443f751725781e0123828f3e98

[Keith Brown]

Fixed documentation and few style errors

Added proper documentation for the macro, and fixed some style problems not caused by me.

Refs #1671

Changeset: 581ed2b356da89f40822bddf3be04a83cc9754a1

[Keith Brown]

To Test:

There is no unit test for this fix. Instead manually load some SPE data into a workspace and save it using SaveSPE (some applicable data can be found in systemtests/SystemTests/AnalysisTests/ReferenceResults/MARIReduction.nxs)

First save it into a place with enough space and permissions to see how big the file should be normally, then save the file to a disk (such as USB key) with no free space. Nothing should end up saved on the USB key as when the save operation fails the file should be removed. Other tests to consider is saving to a disk with free space but not enough for the file (MARIReduction.nxs saves into a 2MB file) or saving to a place where the program doesn't have permissions.

All example instances (bar saving to somewhere with enough space and permissions) should throw and delete the file if possible if the save failed to complete it it's entirety.

[Samuel Jackson]

Testing failed on Ubuntu 12.04 LTS. Algorithm still writes to full drives with a blank file. Also, if a file extension isn't explicitly set "All Files(*)" gets appended to the end of the file name instead.

[Keith Brown]

Debugging had only been done on Windows, wasn't aware it would react differently on other platforms as the platform haddn't been specified on the original report. Now looking to see if i can fix it cross-platform.

[Keith Brown]

Tester has just realised that he'd not compiled the project, reopening for testing

[Samuel Jackson]

Merge remote-tracking branch 'origin/bugfix/1671_disk_full_throw'

[Stuart Campbell]

This ticket has been transferred to github issue ​2518