Ticket #1674 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

parameter "rotx", "roty" and "rotz" apply them absolute rather than relative

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

All parameters apart from "rotx", "roty" and "rotz" are applied absolute rather relative, where absolute means that e.g.

<parameter name="x"> <value val="10.0" /> </parameter>

sets the x-position of a component to 10.0, and NOT moving the component by 10.0 in the x-direction relative to its existing position.

Hence make "rotx", "roty" and "rotz" to be consistent with how all other parameters work.

This also has the added benifit that if someone calls populateInstrumentParameters() multiple times this will make no difference to the end result.

Change History

comment:1 Changed 10 years ago by Anders Markvardsen

(In [6355]) Make parameter "rotx", "roty" and "rotz" apply absolute rather than relative.

Wiki updated.

re #1674

comment:2 Changed 10 years ago by Anders Markvardsen

  • Status changed from new to accepted

comment:3 Changed 10 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:4 Changed 10 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:5 Changed 10 years ago by Vickie Lynch

  • Status changed from verifying to closed

Put roty twice in xml file for one detector and detector was rotated correctly.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2521

Note: See TracTickets for help on using tickets.