Ticket #1684 (closed: fixed)
Ensure Ei values are stored updated and used correctly
Reported by: | Nick Draper | Owned by: | Michael Whitty |
---|---|---|---|
Priority: | major | Milestone: | Iteration 25 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Michael Reuter |
Description
Both ConvertUnits and GetEI should be checked.
GetEI should always store the value in the run object.
ConvertUnits should also store it if it was explicitly added as a parameter (overwriting if already present). ConvertUnits should use the stored value if it was not explicitly provided.
Change History
comment:2 Changed 10 years ago by Michael Whitty
(In [6474]) re #1684 - ConvertUnits will now take the Ei value from the run object if none is provided, will store the input if a value stated by the user, or will throw an exception (std::invalid_argument) if it can't find a value for it at all.
Same changes made to the event workspace convertViaTOF - however would suggest someone tidy up as there's a lot of code copy/paste between the two at the moment.
comment:5 Changed 10 years ago by Michael Whitty
- Status changed from accepted to verify
- Resolution set to fixed
comment:6 Changed 10 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter