Ticket #1732 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

SANS GUI: Fix layout for Linux, Mac and Windows

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: minor Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Make sure the various .ui files produce pretty layouts on all three platforms.

The relevant .ui files are in PythonAPI/scripts/Interface/ui

Change History

comment:1 Changed 10 years ago by Mathieu Doucet

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Mathieu Doucet

(In [6821]) Prettify UI for Mac. Re #1732

comment:3 Changed 10 years ago by Mathieu Doucet

(In [6822]) Make mask work for Mac. Re #1732

comment:4 Changed 10 years ago by Mathieu Doucet

(In [6824]) Work on Mac UI. Re #1732

comment:5 Changed 10 years ago by Mathieu Doucet

(In [6826]) Work on Mac UI. Re #1732

comment:6 Changed 10 years ago by Mathieu Doucet

(In [6827]) Work on Mac UI. Re #1732

comment:7 Changed 10 years ago by Mathieu Doucet

(In [7008]) Added "New" item to File menu to clear the interface. Re #1732

comment:8 Changed 10 years ago by Mathieu Doucet

(In [7042]) Clean mask widget on New event. Re #1732

comment:9 Changed 10 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:10 Changed 10 years ago by Michael Whitty

As I can't really test this on all platforms, I'll just leave a comment.

Mathieu: I don't know what your definition of pretty is, but under Windows the UI doesn't scale well/resize neatly. I think you need to put the tab widget inside a layout which it can expand/shrink with.

Our mac buildserver doesn't seem to have the resolution on vnc to try it out. And I can't connect to the remote linux server atm.

comment:11 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:12 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to reopened
  • Priority changed from major to minor
  • Resolution fixed deleted
  • Milestone changed from Iteration 25 to Iteration 26

I think this is another minor thing that can be pushed to iteration 26. It's true that the interface doesn't resize properly so I think that just needs to be fixed.

I'm moving it to iteration 26 with minor priority.

comment:13 Changed 10 years ago by Mathieu Doucet

  • Milestone changed from Iteration 26 to Iteration 27

comment:14 Changed 10 years ago by Mathieu Doucet

  • Status changed from reopened to accepted

comment:15 Changed 10 years ago by Mathieu Doucet

(In [9397]) UI can now resize. All panels are not fixed. Only checked on linux. Re #1732

comment:16 Changed 10 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:17 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester changed from Martyn Gigg to Michael Whitty

comment:18 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to reopened
  • Resolution fixed deleted
  • Milestone changed from Iteration 27 to Iteration 28

Tested on Win 32 - attention could be given to the affects of resizing on following tabs:

EQSANS variant:

  • "Mask" tab - group boxes do not resize, possible to chop off "remove selected" button

BIOSANS variante:

  • "Instrument" tab - possible to cut off "Log Binning" checkbox. Much of the "Edit Mask" groupbox.
  • "Transmission" tab - possible to cut off "Browse" buttons in "Direct Beam" groupbox.
  • "Background" tab - same as above

Will reopen it but move it to next iteration, as not a dealbreaker, just usability issues.

comment:19 Changed 10 years ago by Mathieu Doucet

(In [9529]) Fix tooltip Re #1732

comment:20 Changed 10 years ago by Mathieu Doucet

(In [9530]) Fix more tooltips. Re #1732

comment:21 Changed 10 years ago by Mathieu Doucet

(In [10099]) Fixing Mac layout Re #1732

comment:22 Changed 10 years ago by Mathieu Doucet

(In [10433]) Working on revamping UI Re #1732

comment:23 Changed 10 years ago by Mathieu Doucet

(In [10446]) Working on revamping UI Re #1732

comment:24 Changed 10 years ago by Mathieu Doucet

(In [10514]) Working on revamping UI Re #1732

comment:25 Changed 10 years ago by Mathieu Doucet

(In [10529]) Working on revamping UI Re #1732

comment:26 Changed 10 years ago by Mathieu Doucet

(In [10531]) Fixed button naming. Re #1732

comment:27 Changed 10 years ago by Mathieu Doucet

(In [10547]) Error reporting... Re #1732

comment:28 Changed 10 years ago by Mathieu Doucet

(In [10557]) Working on new SANS UI. Re #1732

comment:29 Changed 10 years ago by Mathieu Doucet

(In [10558]) Adding scale factor. Re #1732

comment:30 Changed 10 years ago by Mathieu Doucet

(In [10559]) Adding mask. Re #1732

comment:31 Changed 10 years ago by Mathieu Doucet

(In [10584]) Detector panel ready... Re #1732

comment:32 Changed 10 years ago by Mathieu Doucet

(In [10610]) sample tab ready. Re #1732

comment:33 Changed 10 years ago by Mathieu Doucet

(In [10612]) background tab ready - only need to hook up the plot buttons. Re #1732

comment:34 Changed 10 years ago by Mathieu Doucet

(In [10614]) transferring ideas for when I get to the office... Re #1732

comment:35 Changed 10 years ago by Mathieu Doucet

(In [10637]) Hooking up plot (view instrument) button. Re #1732

comment:36 Changed 10 years ago by Mathieu Doucet

(In [10673]) Hooked up plot button to MantidPlot for Background panel. Re #1732

comment:37 Changed 10 years ago by Mathieu Doucet

(In [10677]) Hooked up plot button to MantidPlot for Background panel. Re #1732

comment:38 Changed 10 years ago by Mathieu Doucet

(In [10717]) plotting down for sample data and bck. Re #1732

comment:39 Changed 10 years ago by Mathieu Doucet

(In [10718]) plotting hooked up for detector tab. Re #1732

comment:40 Changed 10 years ago by Mathieu Doucet

(In [10719]) Adding post-reduction updates. Re #1732

comment:41 Changed 10 years ago by Mathieu Doucet

(In [10720]) Adding abs. scale factor. Re #1732

comment:42 Changed 10 years ago by Mathieu Doucet

(In [10726]) Added instrument update. Re #1732

comment:43 Changed 9 years ago by Mathieu Doucet

(In [10742]) Done with UI work. Re #1732

comment:44 Changed 9 years ago by Mathieu Doucet

(In [10744]) Typo. Re #1732

comment:45 Changed 9 years ago by Mathieu Doucet

(In [10750]) Making layout prettier for Windows. Re #1732

comment:46 Changed 9 years ago by Mathieu Doucet

(In [10752]) to_script problem. Re #1732

comment:47 Changed 9 years ago by Mathieu Doucet

(In [10852]) Minor tweaks. Re #1732

comment:48 Changed 9 years ago by Mathieu Doucet

(In [10902]) Minor tweaks. Re #1732

comment:49 Changed 9 years ago by Mathieu Doucet

(In [10912]) Down to pixel alignment for Windows... yes I do mean screen pixels... Re #1732

comment:50 Changed 9 years ago by Mathieu Doucet

(In [10914]) Improve EQSANS a little... Re #1732

comment:51 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:52 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:53 Changed 9 years ago by Mathieu Doucet

  • Status changed from reopened to accepted

The UI now looks pretty good. I'm closing this ticket.

comment:54 Changed 9 years ago by Mathieu Doucet

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:55 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester changed from Michael Whitty to Michael Reuter

comment:56 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

The UI looks good on all platforms even when shrunk to the smallest size possible. Everything is still readable.

comment:57 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2579

Note: See TracTickets for help on using tickets.