Ticket #1737 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Get more information for MultipleScatteringCylinderAbsorption out of the workspace

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: minor Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

There are two parameters TotalFlightPath and ScatteringAngle which can be taken directly from the workspace rather than explicitly provided.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Peter Peterson

comment:2 Changed 10 years ago by Peter Peterson

  • Milestone changed from Iteration 25 to Iteration 26

comment:3 Changed 10 years ago by Peter Peterson

  • Milestone changed from Iteration 26 to Iteration 27

comment:4 Changed 10 years ago by Peter Peterson

  • Status changed from assigned to accepted
  • Milestone changed from Iteration 27 to Iteration 26

comment:5 Changed 10 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [8113]) Refactored the code to be more C++ like and get the instrument geometry from the workspace. Fixes #1737.

comment:6 Changed 10 years ago by Peter Peterson

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:7 Changed 10 years ago by Peter Peterson

  • Status changed from reopened to accepted

The tests currently fail.

comment:8 Changed 10 years ago by Peter Peterson

(In [8119]) Disabled grumpy test. Refs #1737.

comment:9 Changed 10 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [8139]) Reworked the test to reflect the new interface. Fixes #1737.

comment:10 Changed 10 years ago by Peter Peterson

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:11 Changed 10 years ago by Peter Peterson

  • Status changed from reopened to accepted

The tests don't work on windows.

comment:12 Changed 10 years ago by Peter Peterson

(In [8147]) This should fix the tests (again). Refs #1737.

comment:13 Changed 10 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

The last commit made the build server happy.

comment:14 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:15 Changed 10 years ago by Janik Zikovsky

  • Status changed from verifying to closed

Looks like it does what it says, but it needs a wiki page for help...

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2584

Note: See TracTickets for help on using tickets.