Ticket #1745 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Problem with SaveNexus

Reported by: Michael Whitty Owned by: Michael Whitty
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Franz Demmel has reported a problem with SaveNexus, in that it fails on a throw of "tm unable to handle not-a-date-time value" which I have traced to being linked to the AlgorithmHistory::printSelf and DateAndTime::to_tm functions.

Unfortunately, it seems like this is some strange relic of Franz's setup (affects both his laptop and desktop) - but as his machine was setup in a standardised way by ISIS IT then it may become a more widespread problem on release, though I am unable to reproduce it in a development environment to provide more details.

Through trying different versions of the installer, I have narrowed down the introduction of this bug to between [6006] and [6046], so shortly after the last release.

Installers are not available for Win32 intervening period for some reason, but looking at the revision log it would seem that the most likely candidate for introducing it is [6022] (30/08).

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner changed from Nick Draper to Michael Whitty

Try to make the conversion code as bomb proof as possible, perhaps use a date like 1-1-1900 as a proxy for the error message.

comment:2 Changed 10 years ago by Michael Whitty

  • Status changed from assigned to accepted

comment:3 Changed 10 years ago by Michael Whitty

(In [6931]) re #1745 - this will maybe solve a problem with SaveNexus failing on an unhandled exception

comment:4 Changed 10 years ago by Michael Whitty

(In [6961]) reverting changes made in [6931] as they did not have the desired effect. refs #1745

comment:5 Changed 10 years ago by Michael Whitty

(In [6965]) re #1745 - trying to fix a bug in savenexus

comment:6 Changed 10 years ago by Michael Whitty

(In [7004]) refs #1745 - adding unit test to try and ensure the offending exception is dealt with

comment:7 Changed 10 years ago by Michael Whitty

(In [7006]) refs #1745 - filling up the tm struct. doubt it'll make a difference, but to live is to hope.

comment:8 Changed 10 years ago by Michael Whitty

(In [7009]) re #1745 - stepping into unit tests highlighted another position where the to_tm function is called that didn't appear when stepping through the algorithm in debug mode from mantidplot. hopefully this should be more effective in addressing this issue.

however, think the unit test may need looking at - SaveNexusProcessedTest - testExecOnLoadraw - was getting messages in the log on saving outer4 about "logic error in execution of savenexusprocessed, tm unable to handle not-a-date-time value", but the test was passing.

comment:9 Changed 10 years ago by Michael Whitty

  • Status changed from accepted to verify
  • Resolution set to fixed

checked with Franz, issue resolved as of v [7026]

comment:10 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:11 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2592

Note: See TracTickets for help on using tickets.