Ticket #1749 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Geometry: Implement a ParRectangularDetector object to handle parametrized RectangularDetectors

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description


Change History

comment:1 Changed 10 years ago by Janik Zikovsky

(In [6946]) Refs #1749 and #1722: Added IRectangularDetector and ParRectangularDetector in order to handle parametrized locations. I seem to be having trouble getting the values from the DAS logs, but the plotting works though.

comment:2 Changed 10 years ago by Janik Zikovsky

(In [6948]) Refs #1749. Test failed for some reason, trying to see if I can get a more useful message. Unfortunately I do not have a windows machine on which to debug.

comment:3 Changed 10 years ago by Martyn Gigg

(In [6952]) Fixed the windows LoadInstrument tests. The problem was due to the this pointer being used in an initializer list when the object had not been fully constructed yet. Re #1749

comment:4 Changed 10 years ago by Janik Zikovsky

(In [6966]) Refs #1749: Fix calculating mean value for parametrized values.

comment:5 Changed 10 years ago by Janik Zikovsky

(In [6967]) Refs #1749: Fix logParser test. Reverted to old code but added a check in the event of a single value (return the value instead of 0).

comment:6 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:7 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

Pretty ugly code, but it is working. Bounding boxes are a little slow.

comment:8 Changed 10 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:9 Changed 10 years ago by Vickie Lynch

  • Status changed from verifying to closed

Works for SNAP with parameters.

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2596

Note: See TracTickets for help on using tickets.