Ticket #1751 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Missing "else" between lines 90 & 91 of XMLLogFile.cpp

Reported by: Russell Taylor Owned by: Anders Markvardsen
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

Also, add some checks for invalid entries and double-check that it's not possible to return from this function without the return value being set to something meaningful.

Change History

comment:1 Changed 10 years ago by Anders Markvardsen

(In [6869]) Added more tests to XMLlogfileTest and checks in XMLlogfile.cpp and added missing 'else' statement spotted my Russell, which by some C++ fluke appeared to, so far, to have done no harm.

re #1751

comment:2 Changed 10 years ago by Anders Markvardsen

(In [6870]) Fix tests. Problem located by Martyn. Use lexical_cast rather than other string manipulations.

re #1751

comment:3 Changed 10 years ago by Anders Markvardsen

  • Status changed from new to accepted

comment:4 Changed 10 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:6 Changed 10 years ago by Janik Zikovsky

(In [7150]) Refs #1751. Extra doc comments

comment:7 Changed 10 years ago by Janik Zikovsky

  • Status changed from verifying to closed

Test seems reasonable and XML log file parser test is passing.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2598

Note: See TracTickets for help on using tickets.