Ticket #1754 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Create a facility for neutronic properties of atoms

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Iteration 25
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

The short version of this ticket is to bring in all of the constants from NIST into mantid. This will be a new facility in the kernel where there is a bunch of structs that can be accessed through a static method that supplies the symbol (isotopically averaged or select using an alias) or symbol and z-number. This will return a "atom" struct that is read only and consists of the elements:

struct Atom {
  string symbol;
  uint z_number;
  string alias;
  double scattering_length;
  ...
};

Change History

comment:1 Changed 10 years ago by Peter Peterson

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Peter Peterson

(In [6928]) Adding the vast majority of atoms. Refs #1754.

comment:3 Changed 10 years ago by Peter Peterson

(In [6930]) Removed the names of the elements from the struct and put in NAN everywhere that had wierd numbers. Refs #1754.

comment:4 Changed 10 years ago by Peter Peterson

(In [6932]) Added an array for the elements so they can be searched for. Also moved nan to use the standard include statement. Refs #1754.

comment:5 Changed 10 years ago by Peter Peterson

(In [6933]) Added comments to the code. Refs #1754.

comment:6 Changed 10 years ago by Russell Taylor

(In [6935]) Fix for Windows. Re #1754.

comment:7 Changed 10 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [6958]) Put in the factory method and a test for it. Fixes #1754.

comment:8 Changed 10 years ago by Peter Peterson

  • Status changed from verify to reopened
  • Resolution fixed deleted

The build server doesn't seem to like the way I did things.

comment:9 Changed 10 years ago by Peter Peterson

  • Status changed from reopened to accepted

comment:10 Changed 10 years ago by Peter Peterson

(In [6959]) Trying to get the tests to run on the build server. Refs #1754.

comment:11 Changed 10 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [6979]) Messed with the namespace in order to get the tests working. Fixes #1754.

comment:12 Changed 10 years ago by Peter Peterson

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:13 Changed 10 years ago by Peter Peterson

  • Status changed from reopened to accepted

comment:14 Changed 10 years ago by Peter Peterson

(In [6981]) Trying again to make windoze happy. Refs #1754.

comment:15 Changed 10 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

It looks like the build server finally likes my code.

comment:16 Changed 10 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:17 Changed 10 years ago by Janik Zikovsky

  • Status changed from verifying to closed

All looks good, though I did not double-check every value in the table :)

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2601

Note: See TracTickets for help on using tickets.