Ticket #179 (closed: fixed)

Opened 12 years ago

Last modified 5 years ago

Sort out the Workspace data access methods

Reported by: Nick Draper Owned by: Russell Taylor
Priority: major Milestone: Iteration 10
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description

Boost-Python cannot distinguish methds that only differ in overloads be const-ness. Therefore additional mthods have been added to the workspace class to allow read only access to data from python.

We need to rationalise the methods based on this. Something like

  • ReadX, ReadY etc for getting a read access to the data.
  • DataX, DataY etc for getting writable access to the data.

Feel free to consider better method names. The methods need to be well documented and consistent changes made to all of the workspaces.

Change History

comment:1 Changed 12 years ago by Russell Taylor

(In [1177]) Renamed the getX/Y/E methods of Workspace to readX/Y/E to make their intended use clearer. More importantly, they are now non-virtual methods that simply redirect to the const version of dataX/Y/E. Re #179.

comment:2 Changed 12 years ago by Russell Taylor

(In [1181]) Merged IStorable into IWorkspace Property. Re #179.

comment:3 Changed 12 years ago by Russell Taylor

(In [1193]) Moved Alogrithm::fillHistory a little closer to the "path of object-oriented righteousness", as one of my programming teachers would say. Also removed duplicate of methods resulting from Python integration. Re #179.

comment:4 Changed 12 years ago by Russell Taylor

(In [1194]) Project file updates for last set of changes. Re #179.

comment:5 Changed 12 years ago by Russell Taylor

(In [1195]) Added a couple of tests for new Property method. Also corrected a bug with isDefault flag for Workspace properties. Re #179.

comment:6 Changed 12 years ago by Russell Taylor

  • Status changed from new to assigned

Could do with more thorough tests for WorkspaceHistory, AlgorithmHistory & PropertyHistory. Otherwise this task is finished.

comment:7 Changed 12 years ago by Russell Taylor

(In [1196]) qtiplot changes required because of change Algorithm method name. Re #179.

comment:8 Changed 12 years ago by Russell Taylor

(In [1198]) Moved EnvironmentHistory down to Kernel and provided partial implementation. Re #179.

comment:9 Changed 12 years ago by Russell Taylor

(In [1199]) Project file updates for last set of changes. Re #179.

comment:10 Changed 12 years ago by Russell Taylor

  • Status changed from assigned to closed
  • Resolution set to fixed

Comment above about tests for WorkspaceHistory, AlgorithmHistory, PropertyHistory & EnvironmentHistory still applies.

comment:11 Changed 12 years ago by Russell Taylor

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:12 Changed 12 years ago by Russell Taylor

(In [1216]) Compactise AlgorithmHistory printout. Re #179.

comment:13 Changed 12 years ago by Nick Draper

  • Status changed from reopened to closed
  • Resolution set to fixed

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1027

Note: See TracTickets for help on using tickets.