Ticket #1811 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Get beam center finding work under the Mathieu's new framework

Reported by: Steve Williams Owned by: Steve Williams
Priority: critical Milestone: Iteration 29
Component: Python Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Center finding should work in the SANS GUI and SANSRunWindow.cpp, can't import SANSReduction. SANSReduction.py will remain for the time being so not to break legacy scripts.

Change History

comment:1 Changed 10 years ago by Steve Williams

(In [7201]) Fixed some problems with the SANS GUI talking to the Python objects re #1811

comment:2 Changed 10 years ago by Steve Williams

(In [7205]) Lots of small SANS bug fixes re #1811

comment:3 Changed 10 years ago by Steve Williams

(In [7207]) More small SANS bug fixes re #1811

comment:4 Changed 10 years ago by Steve Williams

(In [7213]) One ISIS SANS Python function was failing, explicitly cast float to string re #1811

comment:5 Changed 10 years ago by Steve Williams

(In [7264]) SANS function, deal with the case of a None argument re #1811

comment:6 Changed 10 years ago by Steve Williams

(In [7284]) Allow SANS centre finder (old) to deal with an instrument change re #1811

comment:7 Changed 10 years ago by Steve Williams

(In [7622]) Use / rather than \ on all systems re #1811

comment:8 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:9 Changed 10 years ago by Russell Taylor

(In [8502]) Split off Windows setup into separate file. Revert bit-ness check to test CMAKE_CL_64 (can't rely on "64" being in the generator string - it isn't for NMake). Still works for me if choosing 32 bit Visual Studio generator. Remove explicit path from FindPoco - CMAKE_LIBRARY_PATH is searched anyway. Re #1811.

comment:10 Changed 10 years ago by Russell Taylor

The last check-in should have been under #1881.

comment:11 Changed 10 years ago by Steve Williams

(In [8818]) Fix system tests broken by removing a function needed by the old beam center finder re #1811

comment:12 Changed 10 years ago by Steve Williams

(In [8835]) Fix system tests re #1811

comment:13 Changed 10 years ago by Steve Williams

(In [8836]) Fix system tests re #1811

comment:14 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:15 Changed 10 years ago by Steve Williams

(In [9539]) Use better system test data re #1811

comment:16 Changed 10 years ago by Steve Williams

(In [9540]) Use better system test data re #1811

comment:17 Changed 10 years ago by Martyn Gigg

(In [9655]) Temporary fix to SANS scripts to allow them to load .sav and .s01 files from the GUI. Re #1811

comment:18 Changed 10 years ago by Martyn Gigg

(In [9683]) Better fix for path searching. Will fix the failing SANS tests that my simple fix for sav files broke yesterday. Re #1811

comment:19 Changed 10 years ago by Martyn Gigg

(In [9687]) Catch an exception that only seems to throw on windows. Should fix the FileFinderTest Re #1811

comment:20 Changed 10 years ago by Steve Williams

(In [9725]) Remove a debugging line re #1811

comment:21 Changed 10 years ago by Steve Williams

(In [9843]) In the ISIS SANS Python interface it is possible to alter the name of the output workspace, beam centre finder is being ported to the new framework and there are two bug fixes re #2219 and #1811

comment:22 Changed 9 years ago by Steve Williams

(In [10853]) Rationalise how the SANS transmission is range is set and prepare for the new centre finder re #1811 and #2828 and #2794

comment:23 Changed 9 years ago by Steve Williams

  • Status changed from new to verify
  • Resolution set to fixed

(In [11081]) The SANS centre finder can now be run using ISISCommandInterface.FindBeamCentre(....) fixes #1811

comment:24 Changed 9 years ago by Steve Williams

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:25 Changed 9 years ago by Steve Williams

  • Milestone changed from Iteration 28 to Iteration 29

comment:26 Changed 9 years ago by Steve Williams

(In [11187]) ISIS SANS centre finder now has plotting in the new framework re #1811

comment:27 Changed 9 years ago by Steve Williams

(In [11224]) Tidy up plotting and logging re #1811

comment:28 Changed 9 years ago by Steve Williams

(In [11225]) Revert files that shouldn't have been checked in re #1811

comment:29 Changed 9 years ago by Steve Williams

(In [11264]) Improve plotting after a can subtraction re #1811

comment:30 Changed 9 years ago by Steve Williams

(In [11743]) Fix beam centre bug re #1811

comment:31 Changed 9 years ago by Steve Williams

(In [11767]) It looks like there isn't going to be a new Window's version tonight, remove this test that will just stop anything from getting out re #1811

comment:32 Changed 9 years ago by Steve Williams

(In [12129]) Reinstate the system test re #1811

comment:33 Changed 9 years ago by Steve Williams

(In [12130]) Reinstate the system test re #1811

comment:34 Changed 9 years ago by Steve Williams

(In [12131]) Last correction to make the test compare the correct files re #1811

comment:35 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:36 Changed 9 years ago by Steve Williams

  • Status changed from reopened to accepted
  • Milestone changed from Iteration 30 to Iteration 29

comment:37 Changed 9 years ago by Steve Williams

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:38 Changed 9 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:39 Changed 9 years ago by Michael Reuter

  • Status changed from verifying to closed

The procedure seems to work OK.

comment:40 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2658

Note: See TracTickets for help on using tickets.