Ticket #186 (closed: fixed)

Opened 12 years ago

Last modified 5 years ago

Use of Offset values associated with unit conversion

Reported by: Nick Draper Owned by: Russell Taylor
Priority: major Milestone: Iteration 11
Component: Keywords: Units
Cc: Blocked By:
Blocking: Tester:

Description

Some instruments have specified offsets for use in unit conversions (or perhaps just after). Unfortunately the information used to derive the offset is not enough to correct the geometry as the offset is specified as a compound correction to LsinTheta. This could be applied as a post conversion fix within the conversion algorithms or perhaps more usefully a separate algorithm.

For now you should assume the file structure is that of the .cal files available in the TEST\Data directory. DiffractionFocussing reads the same files and may be of some use.

Once this is in place DiffractionFocussing should be altered to make use of this new functionality.

Change History

comment:1 Changed 12 years ago by Russell Taylor

  • Status changed from new to assigned

comment:2 Changed 12 years ago by Russell Taylor

(In [1292]) Some tidying up as I've been getting started on adding detector offsets. Main changes: ConvertUnits checks if the input workspace already has the desired output unit. Units are copied over in the create-from-parent workspace factory method. Re #186

comment:3 Changed 12 years ago by Russell Taylor

(In [1330]) Moved sample so that beam comes down z axis. Re #186.

comment:4 Changed 12 years ago by Russell Taylor

(In [1331]) Added AlignDetectors algorithm to correct for detector misalignments. Does so in the course of a TOF to dSpacing unit conversion. Also corrected calculation of 2theta - previously assumed that beam was coming down z axis, which is not necessarily the case. Involved addition of a the method V3D::angle to get the angle between two vectors and the method Instrument::detectorTwoTheta to get the angle between the beam and a given detector. Re #186.

comment:5 Changed 12 years ago by Russell Taylor

(In [1332]) Updated vcproj file to include AlignDetectors. Re #186

comment:6 Changed 12 years ago by Russell Taylor

(In [1341]) I'd inadvertently broken DiffractionFocussing. Re #186.

comment:7 Changed 12 years ago by Nick Draper

  • Status changed from assigned to closed
  • Resolution set to fixed

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 1034

Note: See TracTickets for help on using tickets.