Ticket #1901 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Allow MaskDetectors to copy masking from another workspace

Reported by: Nick Draper Owned by: Martyn Gigg
Priority: critical Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

Add another input ws property. The algortihhm should then copy the masking from that one and apply it to the other WS.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner changed from Martyn Gigg to Andrei Savici

comment:2 Changed 10 years ago by Andrei Savici

  • Status changed from assigned to accepted

comment:3 Changed 10 years ago by Martyn Gigg

  • Owner changed from Andrei Savici to Martyn Gigg
  • Status changed from accepted to assigned

comment:4 Changed 10 years ago by Martyn Gigg

  • Status changed from assigned to accepted

comment:5 Changed 10 years ago by Martyn Gigg

(In [7946]) Allow optional workspace properties on algorithms. Required for implementing copy of masks from another workspace. Also cleanup a couple of test failures in algorithms. Re #1901

comment:6 Changed 10 years ago by Martyn Gigg

(In [7959]) Update a test. Re #1901

comment:7 Changed 10 years ago by Martyn Gigg

(In [7961]) Add an additional optional workspace argument to MaskDetectors to allow masking to be copied over from this workspace. Re #1901

comment:8 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:9 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:10 Changed 10 years ago by Martyn Gigg

(In [7969]) Spoke too soon closing the maskdetectors ticket. This is the correct thing to do along with an improved test that wouldhave picked up the bad thing that I did. Also cleared some warnings and removed std::cout output from FileFinderTest. Re #1901

comment:11 Changed 10 years ago by Martyn Gigg

  • Status changed from reopened to accepted

comment:12 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:13 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:14 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

tested this when testing ticket for ExtractMasking #1902

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2748

Note: See TracTickets for help on using tickets.