Ticket #1914 (closed: fixed)
Eliminate the use of CNCS_7850 data files in unit tests
Reported by: | Russell Taylor | Owned by: | Andrei Savici |
---|---|---|---|
Priority: | major | Milestone: | Iteration 27 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Michael Whitty |
Description
This is part of the drive to reduce the size of our subversion repository and elimate the reading of data files in unit tests unless absolutely necessary.
CNCS_7850_event.nxs and CNCS_7850_neutron_event.dat are respectively the 6th & 9th largest files currently used in unit tests!
Their use features in:
- SumNeighboursTest
- LoadLogsFromSNSNexusTest
- LoadNexusMonitorsTest
- LoadSNSEventNexusTest
- FilterByLogValueTest
- MergeRunsTest
- LoadEventPreNeXusTest
- LoadTOFRawNeXusTest
Tests that have to load a file (i.e. those testing file loading algorithms) should switch to using a much smaller file (N.B. pre-eventnexus files could be truncated with dd). Others should create fictional data by using routines like WorkspaceCreationHelper.hh. If an algorithm under test requires the instrument geometry in any way then you may have to wait for completion of ticket #1899.
See me if you have any questions (or Janik, who I believe wrote most of these tests).
I believe that Stuart said there are lots of files from 5 minute CNCS runs around.
Change History
comment:2 Changed 10 years ago by Andrei Savici
In SumNeighboursTest, the use of CNCS_7850_event.nxs is commented out. Will delete that line. There is no real test for this algorithm
In LoadLogsFromSNSNexusTest, the use of CNCS_7850_event.nxs is commented out. Will delete that line. The xtestSpeed test is redundant, plus it uses a file from /home/8oz, which is not found on my system.
comment:4 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 26 to Iteration 27
Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.
comment:10 Changed 10 years ago by Andrei Savici
comment:11 Changed 10 years ago by Andrei Savici
comment:12 Changed 10 years ago by Andrei Savici
comment:13 Changed 10 years ago by Andrei Savici
comment:14 Changed 10 years ago by Andrei Savici
comment:15 Changed 10 years ago by Andrei Savici
- Status changed from accepted to verify
- Resolution set to fixed
The following tests are using CNCS_7860 when running (or have functions that can):
- API/test/FileFinderTest.h: the event NeXus
- DataHandling/test/LoadEventPreNeXusTest.h: the event preNeXus
- DataHandling/test/LoadPreNeXusMonitorsTest.h: the preNeXus monitor and runinfo
- Algorithms/test/FilterByTimeTest.h: the event preNeXus
- Algorithms/test/AlignDetectorsTest.h: the event preNeXus
- Algorithms/test/MergeRunsTest.h: the event preNeXus
- Algorithms/test/FilterByLogValueTest.h: the event NeXus
- Algorithms/test/ConvertUnitsTest.h: the event preNeXus
- Algorithms/test/MemoryLeakTest.h: nothing - everything is commented out. I left a comment in the file if they need to use the event NeXus
] - Algorithms/test/ChangeBinOffsetTest.h: the event preNeXus
- Nexus/test/LoadNexusMonitorsTest.h: the event NeXus
- Nexus/test/LoadSNSEventNexusTest.h: the event NeXus and the event preNeXus
- Nexus/test/SaveNexusProcessedTest.h: the event preNeXus, but it does not work (the test was not supposed to run)
- Nexus/test/LoadTOFRawNeXusTest.h: teh histogram NeXus, but it does not work (the test was not supposed to run). If this test is eliminated, CNCS_7860.nxs can be deleted
comment:16 Changed 10 years ago by Michael Whitty
- Status changed from verify to verifying
- Tester set to Michael Whitty
comment:17 Changed 10 years ago by Michael Whitty
- Status changed from verifying to closed
Andrei's summary is accurate.
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 2761