Ticket #1935 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Bug in saving user properties containing line continuation characters

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Whitty

Description

If there is any text directly before a line that has a \ at then end within the Mantid.user.properties file then that line gets prepended to the saved version.

Example: Original user properties file contains: 

# All paths should contain forward slashes
datasearch.directories = '/home/dmn58364/mantidproject/data';\
'/home/dmn58364/mantidproject/otherdata'
  • Start MantidPlot
  • Open the user preferences dialog and click apply then cancel.
  • Re-open the Mantid.user.properties file and the above line will look like 
    # All paths should contain forward slashes
# All paths should contain forward slashesdatasearch.directories = '/home/dmn58364/mantidproject/data';\
'/home/dmn58364/mantidproject/otherdata'

Change History

comment:1 Changed 10 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [7525]) Fix a small bug when saving a user properties file that contains line continuation characters. Fixes #1935

comment:3 Changed 10 years ago by Russell Taylor

(In [7542]) Have MatrixWorkspace hold a cow_ptr to the parameter map once again to avoid code duplication. Re #1935 - temporary hijack of ticket :)

comment:4 Changed 10 years ago by Russell Taylor

I didn't mean to put this under a completely irrelevant ticket! Meant to put #1934!

comment:5 Changed 10 years ago by Michael Whitty

  • Status changed from verify to verifying
  • Tester set to Michael Whitty

comment:6 Changed 10 years ago by Michael Whitty

  • Status changed from verifying to closed

no longer prepends preceding lines.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2782

Note: See TracTickets for help on using tickets.