Ticket #1966 (assigned)
Split up work done by LoadDetectorInfo
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Backlog |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: |
Description
The algorithm as it currently stand is not very useable. The main problem is that it both loads information from the raw file and adjusts the X bins meaning that it has to appear in a very odd place in conversion scripts.
It's functionality should be changed to simply load the raw file information in to the parameter map. This way the load step in the inelastic scripts can be isolated properly.
The offset information can then be used at the most appropriate point in a script by either a modified existing algorithm or by a new algorithm.
My suggestion would be a modification to ChangeBinOffset so that it has an option to correct the X data for the efficiency information that may have been loaded.
What would be nice as well would be to change the way that the algorithm loads the parameters. Most of the time the numbers are identical for each detector and currently we store an entry in the parameter map for each one. It would be more efficient to have an instrument wide parameter set to the first value in the list within the raw file and then only set detector level ones that are different.
Change History
comment:1 Changed 10 years ago by Nick Draper
- Owner set to Martyn Gigg
- Status changed from new to assigned
comment:2 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 26 to Iteration 27
Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.
comment:3 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 27 to Iteration 28
Bulk move of tickets at the end of iteration 27
comment:4 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 28 to Iteration 29
Bulk move of tickets at the end of iteration 28
comment:5 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 29 to Iteration 30
Accepted and assigned tickets moved at iteration 29 code freeze
comment:6 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 30 to Iteration 31
Bulk move of tickets to iteration 31 at the iteration 30 code freeze
comment:7 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 32 to Iteration 33
Moved to iteration 33 at iteration 32 code freeze
comment:8 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.1 to Release 2.2
Moved at end of release 2.1
comment:9 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.2 to Release 2.3
Moved at the end of release 2.2
comment:10 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to milestone 2.4
comment:12 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.5 to Release 2.6
comment:13 Changed 7 years ago by Martyn Gigg
- Milestone changed from Release 2.6 to Release 2.7
Batch move to 2.7
comment:17 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
Bulk move to assigned at the introduction of the triage step
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 2813
I agree apart from I would also like to encourage the movement of the wall thickness data etc to the instrument parameter file.
With this approach you could specify more constant parameters once higher up the inst tree
This way would also support nexus files.