Ticket #1984 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Minus: Implement for event workspace, using weights

Reported by: Janik Zikovsky Owned by: Janik Zikovsky
Priority: major Milestone: Iteration 26
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

WS1 - WS2 = WS1's events with WS2's events appended, but with a negative weight of -1.0.

Magic!

Change History

comment:1 Changed 10 years ago by Janik Zikovsky

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [7721]) Minus and Multiply algorithms now use event weights to preserve the use of EventWorkspace longer in processing. Fixes #1984 and Refs #1781.

comment:3 Changed 10 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:4 Changed 10 years ago by Andrei Savici

  • Status changed from verifying to reopened
  • Resolution fixed deleted

I loaded w1 and w2 from the same file. w3=w1-w2. I cannot rebin w3

Rebin: EventList::generateErrorsHistogram() called for a weighted EventList. Try generateHistogramsForWeights() instead. Error in execution of algorithm Rebin: Rebin: error (see log)

comment:5 Changed 10 years ago by Janik Zikovsky

(In [8143]) Fixes #2072, Refs #1984. Bug when rebinning Weighted EventWorkspace.

comment:6 Changed 10 years ago by Janik Zikovsky

  • Status changed from reopened to accepted

comment:7 Changed 10 years ago by Janik Zikovsky

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 10 years ago by Andrei Savici

  • Status changed from verify to verifying

comment:9 Changed 10 years ago by Andrei Savici

  • Status changed from verifying to closed

Works now

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2831

Note: See TracTickets for help on using tickets.