Ticket #2053 (closed: fixed)
Allow finding bin mask fractions with a command like, it = mask.find(j)
| Reported by: | Steve Williams | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 2.1 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Russell Taylor |
Description
The current storage type (in MatrixWorkspace) for masked bins:
typedef std::set< std::pair<int,double> > MaskList;
doesn't allow searching on bin index. std::map<int, double> would
Change History
comment:1 Changed 10 years ago by Nick Draper
- Owner set to Russell Taylor
- Status changed from new to assigned
comment:2 Changed 10 years ago by Russell Taylor
I agree with this change. This came up when I suggested to Steve that he could make his new Qxy code simpler by using a find method. He then pointed out that he couldn't because the storage was a set of pairs.
I guess that there wasn't a use case for finding if a bin was masked in this manner when I first wrote the masking code. Should be a fairly simple change to implement and performance change should be close to zero (the internal storage will be essentially the same).
comment:4 Changed 10 years ago by Nick Draper
- Milestone changed from Iteration 27 to Iteration 28
Bulk move of tickets at the end of iteration 27
comment:6 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 28 to Iteration 29
Bulk move of tickets at the end of iteration 28
comment:7 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 29 to Iteration 30
Accepted and assigned tickets moved at iteration 29 code freeze
comment:8 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 30 to Iteration 31
Bulk move of tickets to iteration 31 at the iteration 30 code freeze
comment:9 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 32 to Iteration 33
Moved to iteration 33 at iteration 32 code freeze
comment:11 Changed 9 years ago by Martyn Gigg
Refs #2053. Change internal storage type for masked bins.
The stored structure should be similar but the map lookup will be faster.
Changeset: 84f2aaf30067366ef12ea9acade6500b1537bf77
comment:12 Changed 9 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:13 Changed 8 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 2900
Russell, can you give me your opinion on this?