Ticket #2102 (assigned)
Improvements to Find peaks
| Reported by: | Anders Markvardsen | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | minor | Milestone: | Backlog |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: |
Description
Ensure that params in IDF are used to set params in fit functions generated from hitting the 'Find Peaks' button.
Ensure that 'Find peaks' only find peaks within the area specified by the left/right vertical adjustable lines
See observations below.
First observation in MantidPlot:
1) use HRP39182.raw 2) add a BackToBackExponential function 3) Look at its parameters and note that e.g. the instrument parameters A and B parameters are tied to parameter values set in the IDF. 4) Hit the 'Find Peaks' button 5) This generates a list of BackToBackExponential function 6) HOWEVER, the A and B params of these functions does not appear to have be set from params in the in IDF!
Second observation:
1) Load focussedGEM38370_TOF.nxs 2) Use IkedaCarpenterPV function 3) When using the FindPeaks algorithms it appears to find peaks outside the area specified by the left/right vertical adjustable lines for selecting the fitting area
Change History
comment:2 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 28 to Iteration 29
Bulk move of tickets at the end of iteration 28
comment:3 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 29 to Iteration 30
"New" tickets moved at the code freeze of iteration 29
comment:4 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 30 to Iteration 31
Bulk move of tickets to iteration 31 at the iteration 30 code freeze
comment:5 Changed 9 years ago by Anders Markvardsen
- Owner changed from Anders Markvardsen to Karl Palmen
- Status changed from new to assigned
First step is to test if 1) and 2) above still applies, we can test this together when convenience
comment:7 Changed 9 years ago by Nick Draper
- Milestone changed from Iteration 32 to Iteration 33
Moved to iteration 33 at iteration 32 code freeze
comment:8 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.1 to Release 2.2
Moved at end of release 2.1
comment:9 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.2 to Release 2.3
Moved at the end of release 2.2
comment:10 Changed 8 years ago by Nick Draper
- Milestone changed from Release 2.3 to Release 2.4
Moved to milestone 2.4
comment:15 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to backlog at the code freeze for R2.6
comment:16 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
bulk move to assigned at the into of the triage step
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 2949
Bulk move of tickets at the end of iteration 27