Ticket #2103 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Convert FindPeaks to use new type fitting functions

Reported by: Anders Markvardsen Owned by: Karl Palmen
Priority: minor Milestone: Release 2.0
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

The FindPeaks algorithm is currently using old style Fit1D functions. Change this to use new style Fit functions instead.

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Owner set to Anders Markvardsen
  • Status changed from new to assigned

comment:2 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:6 Changed 9 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Karl Palmen

comment:7 Changed 9 years ago by Anders Markvardsen

Estimated to take one man days

comment:8 Changed 9 years ago by Karl Palmen

It seems that the work has already been done at ​http://doxygen.mantidproject.org/FindPeaks_8cpp_source.html with the old (1D-using) code commented out. I'll try the new code found there in the unit test.

comment:9 Changed 9 years ago by Karl Palmen

Test ran without any GaussianID warnings, but failed because the results were not as expected by the test.

comment:10 Changed 9 years ago by Anders Markvardsen

By coincidence Wenduo fixes this, in fact last Friday, see #3955

comment:11 Changed 9 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:12 Changed 9 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

Duplicate of ticket #3955 now fixed.

comment:13 Changed 9 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:14 Changed 9 years ago by Vickie Lynch

  • Status changed from verifying to closed

I will test duplicate 3955 and close this ticket.

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​2950

Note: See TracTickets for help on using tickets.