Ticket #2142 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

SANS: The mask file reading need to warn about ignored commands

Reported by: Nick Draper Owned by: Steve Williams
Priority: critical Milestone: Iteration 27
Component: Mantid Keywords:
Cc: richard.heenan@… Blocked By:
Blocking: #2284 Tester: Brett Tully

Description

The routine that reads Mask (User) files needs to flag up warnings when, for example, it encounters a command it doesn't understand.

Change History

comment:1 Changed 10 years ago by Steve Williams

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Steve Williams

  • Status changed from accepted to verify
  • Resolution set to fixed

(In [8318]) SANS user files with lines starting with "print" will print a message to the log. Any unrecognised commands produce a warning or throw fixes #2142 re #2160

comment:3 Changed 10 years ago by Nick Draper

  • Blocking 2284 added

comment:4 Changed 10 years ago by Brett Tully

  • Status changed from verify to verifying
  • Tester set to Brett Tully

comment:5 Changed 10 years ago by Brett Tully

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Works correctly when mask is loaded through the GUI, however, no messages or warnings are present when mask is loaded through a script.

comment:6 Changed 10 years ago by Brett Tully

comment:7 Changed 10 years ago by Steve Williams

(In [9502]) Ensuring that warning messages are printed re #2142 and #2160

comment:8 Changed 10 years ago by Steve Williams

  • Status changed from reopened to accepted

The following commands (with correct path) should print to the script console. The results log depends on logging level.

from ISISCommandInterface import *

LOQ()
MaskFile(r"C:\mantid\Test\Data\LOQ\MASK.094AA")

comment:9 Changed 10 years ago by Brett Tully

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:10 Changed 10 years ago by Brett Tully

  • Status changed from verify to verifying

comment:11 Changed 10 years ago by Brett Tully

  • Status changed from verifying to closed

Issue resolved.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 2989

Note: See TracTickets for help on using tickets.