Ticket #2153 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Investigate: Check we are using memory responsibly in SANS reduction

Reported by: Nick Draper Owned by: Steve Williams
Priority: critical Milestone: Iteration 27
Component: Mantid Keywords:
Cc: Richard.heenan@… Blocked By:
Blocking: Tester: Martyn Gigg

Description

Richard Heenan: Combine “convert to wavelength” and “rebin” in the main detector data reduction to avoid the memory requirements of the huge intermediate ragged workspace. This ought to speed up data reduction and allow more workspace storage before users run out of memory.

Nick Draper: Check we are using the same input and output workspaces for convertunits and rebin so we work in place or overwrite. If we are storing the workspace for any length of time we nee to know why and present the implications.

This is an investigative task in the first instance.

Change History

comment:1 Changed 10 years ago by Steve Williams

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Steve Williams

(In [8601]) The SANS errors workspace sometimes wasn't getting deleted. Deal with the situation where the full wave range transmission workspace has a different rebinning from the sample re #2153

comment:3 Changed 10 years ago by Steve Williams

(In [8620]) Temporally reverse some changes until the Windows installers are back in action re #2153

comment:4 Changed 10 years ago by Steve Williams

(In [8638]) Deal with the situation where the full wave range transmission workspace has a different rebinning from the sample re #2153

comment:5 Changed 10 years ago by Steve Williams

  • Status changed from accepted to verify
  • Resolution set to fixed

Throughout the SANS analysis the input and output workspaces from ConvertUnits() are the same. This causes Mantid to write the data in place which is the most memory efficient that Mantid can currently be. In all those instances Rebin() or InterpolatingRebin() is called with the same in/output workspaces reducing memory usage and this step can't be done more efficiently.

comment:6 Changed 10 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:7 Changed 10 years ago by Martyn Gigg

  • Status changed from verifying to closed

In 1.1.9493, the output seems reasonable throughout the analysis given the required data that users wish us to leave at the end. The changes around the errors workspace seem sensible and they haven't affected the results.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3000

Note: See TracTickets for help on using tickets.