Ticket #2196 (closed: fixed)
Move test helpers into their own package
Reported by: | Peter Peterson | Owned by: | Martyn Gigg |
---|---|---|---|
Priority: | major | Milestone: | Iteration 27 |
Component: | Infrastructure | Keywords: | |
Cc: | doucetm@… | Blocked By: | |
Blocking: | Tester: | Janik Zikovsky |
Description
As the tests are now compiled separately then linked together having Mantid/Geometry/test/ComponentCreationHelpers.hh, Mantid/Kernel/test/TestChannel.hh, and Mantid/Algorithms/test/WorkspaceCreationHelper.hh implemented in the headers makes an error upon linking.
Move these functions over into a separate package and split them into declaration (.h) and implementation (.cpp) files that the current tests can use.
Change History
comment:1 Changed 10 years ago by Nick Draper
- Owner set to Russell Taylor
- Status changed from new to assigned
comment:2 Changed 10 years ago by Martyn Gigg
- Status changed from assigned to accepted
- Owner changed from Russell Taylor to Martyn Gigg
I had talked to Russell and Peter about this and am nearly there so I'll steal it.
comment:4 Changed 10 years ago by Martyn Gigg
(In [8527]) Reorganised using namespace declarations that were polluting the test helper headers. All are now in the cpp files. Ported over the SANSInstrumentCreationHelper and added it to the ComponentCreationHelper file. All the helper classes are ported but Scons knows nothing so the originals are left in their place. Re #2196
comment:10 Changed 10 years ago by Martyn Gigg
comment:11 Changed 10 years ago by Peter Peterson
comment:12 Changed 10 years ago by Peter Peterson
comment:14 Changed 10 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:15 Changed 10 years ago by Janik Zikovsky
- Status changed from verify to verifying
- Tester set to Janik Zikovsky
comment:16 Changed 10 years ago by Janik Zikovsky
- Status changed from verifying to closed
This has been working well for several weeks now, and I use the helpers frequently.
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 3043