Ticket #2266 (closed: invalid)

Opened 10 years ago

Last modified 5 years ago

Status of ANN Library

Reported by: Michael Whitty Owned by: Nick Draper
Priority: minor Milestone: Release 2.5
Component: Mantid Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester:

Description

In reverse chronological order.

Could you create a ticket that Nick can triage? I think it is fairly low
priority, but something that should be noted so people can, in principle,
know what is going on.

P^2

-----Original Message-----
From: "michael.whitty@stfc.ac.uk" <michael.whitty@stfc.ac.uk>
Date: Fri, 21 Jan 2011 11:34:03 -0500
To: Peter Peterson <petersonpf@ornl.gov>
Cc: "nick.draper@stfc.ac.uk" <nick.draper@stfc.ac.uk>,
"russell.taylor@stfc.ac.uk" <russell.taylor@stfc.ac.uk>
Subject: RE: ANN library in Kernel

>Peter,
>
>I was originally intending to cut out a lot of the stuff in it which we
>don't use, but this wasn't a priority as we neared the release and it
>certainly hasn't been since. Features before style and all that jazz.
>
>If people want to grumble, well - I have no personal reason for wanting
>it to be in Kernel, so if someone feels they can move it somewhere
>better and avoid issues mentioned they may do so. The only place that
>references it currently is the NearestNeighbours class in Geometry so
>moving it wouldn't really impact on that many places.
>
>Mike
>
>-----Original Message-----
>From: Peterson, Peter F. [mailto:petersonpf@ornl.gov]
>Sent: 21 January 2011 16:24
>To: Whitty, Michael (STFC,RAL,ISIS)
>Cc: Taylor, Russell J.
>Subject: Re: ANN library in Kernel
>
>That sounds reasonable, but maybe it should be in its own sub-package
>then
>rather than hiding it within kernel. That would help clarify what it is.
>That being said it does face a real danger of being forked if it sits in
>our main code area.
>
>Either way, I've heard lots of grumbling about the library showing up in
>such a funny place since it is an outside project. Unfortunately the
>message that ANN was Nick approved never made it across the pond.
>
>P^2
>
>-----Original Message-----
>From: "michael.whitty@stfc.ac.uk" <michael.whitty@stfc.ac.uk>
>Date: Fri, 21 Jan 2011 11:15:30 -0500
>To: Peter Peterson <petersonpf@ornl.gov>
>Cc: "Taylor, Russell J." <taylorrj@ornl.gov>
>Subject: RE: ANN library in Kernel
>
>>Peter,
>>
>>ANN has some options that must be set at compile time that became
>>apparent when I was investigating its use. For this reason relying on
>>the package managers of Ubuntu or other Linux distributions would not
>be
>>sufficient for the need within Mantid.
>>
>>This was discussed with Nick, who suggested that we would do better to
>>assimilate the code within Kernel rather than adding another dependency
>>in Third_Party.
>>
>>Mike
>>
>>-----Original Message-----
>>From: Peterson, Peter F. [mailto:petersonpf@ornl.gov]
>>Sent: 21 January 2011 16:05
>>To: Whitty, Michael (STFC,RAL,ISIS)
>>Cc: Taylor, Russell J.
>>Subject: ANN library in Kernel
>>
>>Michael,
>>
>>Before the last release you added the ANN package to Kernel. While I
>>understand it is being used in mantid, there is the question of why it
>>was placed in kernel rather than Third_Party where similar libraries
>are
>>found.  It is available as a regular install on ubuntu and assuming
>that
>>you aren't doing anything other than using it you should move it
>outside
>>of mantid itself and add the library to the build system.
>>
>>P^2

Change History

comment:1 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:2 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:6 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:7 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:9 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

comment:10 Changed 8 years ago by Nick Draper

  • Status changed from new to verify
  • Resolution set to wontfix

if this is an issue it can be reraised by the dev team during a maintenance period

comment:11 Changed 8 years ago by Nick Draper

test

comment:12 Changed 8 years ago by Nick Draper

  • Status changed from verify to closed
  • Resolution changed from wontfix to invalid

closed

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3113

Note: See TracTickets for help on using tickets.