Ticket #2379 (closed: fixed)

Opened 10 years ago

Last modified 5 years ago

Integrate Single Crystal Diffraction peak

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Iteration 30
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Janik Zikovsky

Description

New algorithm with same functionality as TOFINT in ISAW. Given a peak, integrate a box in x and y of detector space around the peak, fit the integrated values in time of flight using IkedaCarpenter function, and then integrate fit.

Change History

comment:1 Changed 10 years ago by Vickie Lynch

  • Status changed from new to accepted

comment:2 Changed 10 years ago by Vickie Lynch

(In [9413]) Refs #2379 TOF Integration of peak; add options to SumNeighbors for one bank and pixel

comment:3 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:4 Changed 10 years ago by Vickie Lynch

(In [9564]) Refs #2379 Integrate single crystal diffraction peaks using input from ISAW

comment:5 Changed 10 years ago by Vickie Lynch

(In [9633]) Refs #2379 Trying IkedaCarpenterPV to integrate 4 largest peaks

comment:6 Changed 10 years ago by Vickie Lynch

(In [9634]) Refs #2379 Reverted some files

comment:7 Changed 10 years ago by Vickie Lynch

(In [9635]) Refs #2379 Change to include file added

comment:8 Changed 10 years ago by Vickie Lynch

(In [9685]) Refs #2379 Calculate ISAW TOF for peaks and find in TOF grid; Use TOF grid for integration with IkedaCarpenterPV

comment:9 Changed 10 years ago by Ruth Mikkelson

(In [9732]) refs #2379. PeaksWorkspace

comment:10 Changed 10 years ago by Ruth Mikkelson

(In [9733]) refs #2379. PeaksWorkspace

comment:11 Changed 10 years ago by Dennis Mikkelson

(In [9737]) Temporarily commented out addColumn() method since it didn't compile on RHEL6. refs #2379

comment:12 Changed 10 years ago by Vickie Lynch

(In [9817]) Refs #2379 Found workaround for evaluating IkedaCarpenterPV at more points than original data

comment:13 Changed 10 years ago by Vickie Lynch

(In [9931]) Refs #2379 Moving SingleCrystalTOFIntegration to Crystal directory

comment:14 Changed 10 years ago by Vickie Lynch

(In [9934]) Refs #2379 SingleCrystalTOFIntegration renamed PeakIntegration in Crystal directory

comment:15 Changed 10 years ago by Vickie Lynch

(In [9951]) Refs #2379 Using PeaksWorkspace in PeakIntegration

comment:16 Changed 10 years ago by Vickie Lynch

(In [9957]) Refs #2379 Peaks workspace no longer has L2=0 and constant changed for using m not cm

comment:17 Changed 10 years ago by Vickie Lynch

(In [9960]) Refs #2379 Save integrated count and error in PeaksWorkspace

comment:18 Changed 10 years ago by Vickie Lynch

(In [9963]) Refs #2379 Remove OutputWorkspace; sort peaks in descending order

comment:19 Changed 10 years ago by Vickie Lynch

(In [9978]) Refs #2379 Use IkedaCarpenter parameters from largest peak for small peaks

comment:20 Changed 10 years ago by Janik Zikovsky

(In [9984]) Refs #2379: PeaksWorkspace test stub.

comment:21 Changed 10 years ago by Vickie Lynch

(In [10020]) Refs #2379 Get l2 from peak position so it can be removed from PeakWorkspace

comment:22 Changed 10 years ago by Ruth Mikkelson

(In [10031]) Refs #2379. Caught Errors to report them. Fixed several errors in the write method

comment:23 Changed 10 years ago by Ruth Mikkelson

(In [10050]) refs #2379. Added logging and new initialization routines

comment:24 Changed 10 years ago by Ruth Mikkelson

(In [10051]) Refs #2379, Added documentation and overrode the addColumn method

comment:25 Changed 10 years ago by Ruth Mikkelson

(In [10069]) Refs #2379, Moved file variables to class variables. Implemented the destructor.

comment:26 Changed 10 years ago by Vickie Lynch

(In [10081]) Refs #2379 No ties for final fit; indentions added

comment:27 Changed 10 years ago by Ruth Mikkelson

(In [10139]) refs #2379. Added Test program for PeaksWorkspace. Added several other methods to get and set information into the PeaksWorkspace

comment:28 Changed 10 years ago by Janik Zikovsky

(In [10144]) Refs #2379: Fix for test of PeaksWorkspace - the problem was with different line endings windows vs linux.

comment:29 Changed 10 years ago by Ruth Mikkelson

(In [10261]) Refs #2379. Added Mantid documentation.

Eliminated L2 parameters from addPeaks Eliminated the L2 TableColumn Added const where applicable Implemented indexing peaks with an orientation matrix

comment:30 Changed 10 years ago by Vickie Lynch

(In [10338]) Refs #2379 #2446 Integrate peaks using pf->function for IkeidaCarpenter

comment:31 Changed 10 years ago by Vickie Lynch

(In [10606]) Refs #2379 Use PreserveEvents for Rebin; background changes

comment:32 Changed 10 years ago by Vickie Lynch

(In [10635]) Refs #2379 Using composite function to fit peaks

comment:33 Changed 10 years ago by Vickie Lynch

(In [10636]) Refs #2379 Reduce range of integration if near detector edge for SingleNeighbourhood

comment:34 Changed 10 years ago by Vickie Lynch

(In [10681]) Refs #2379 Changes to fitting function

comment:35 Changed 10 years ago by Vickie Lynch

(In [10685]) Refs #2379 Save fit parameters for smaller peaks

comment:36 Changed 10 years ago by Ruth Mikkelson

(In [10696]) Added test case for the method to sethkl with an orientation matrix. refs #2379

comment:37 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:38 Changed 9 years ago by Vickie Lynch

Commit message that is missing:

(In [11688]) Refs #2379 Some cleanup of PeakIntegration

comment:39 Changed 9 years ago by Vickie Lynch

(In [11721]) Refs #2379 Print some into to debug test on Mac and windows

comment:40 Changed 9 years ago by Vickie Lynch

(In [11725]) Refs #2379 Print some more info for debugging test

comment:41 Changed 9 years ago by Vickie Lynch

(In [12011]) Refs #2379 Better initial guesses for fit parameters

comment:42 Changed 9 years ago by Vickie Lynch

(In [12192]) Refs #2379 Calculate errors correctly for nonPoisson distributions

comment:43 Changed 9 years ago by Vickie Lynch

(In [12507]) Refs #2379 Threads for each detector bank; mask pixels outside peak

comment:44 Changed 9 years ago by Vickie Lynch

(In [12508]) Refs #2379 PeaksWorkspace threadSafe

comment:45 Changed 9 years ago by Vickie Lynch

(In [12653]) Refs #2379 fix warning

comment:46 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

Accepted and assigned tickets moved at iteration 29 code freeze

comment:47 Changed 9 years ago by Vickie Lynch

In [13127]:

Refs #2379 Detector pixels are correct for spectra again

comment:48 Changed 9 years ago by Vickie Lynch

In [13385]:

Refs #2379 FitSlices option for PeakIntegration

comment:49 Changed 9 years ago by Vickie Lynch

In [13478]:

Refs #2379 Positive gamma; remove OutPeaksWorkspace from IntegratePeakTimeSlices subalgorithm

comment:50 Changed 9 years ago by Vickie Lynch

In [13517]:

Refs #2379 Integrate peaks in parallel; calculate Qspan once

comment:51 Changed 9 years ago by Vickie Lynch

In [13607]:

Refs #2379 Fix Unknown property search Object Parameters error

comment:52 Changed 9 years ago by Vickie Lynch

In [13618]:

Refs #2379 Rewrite of PeakIntegration & tests

comment:53 Changed 9 years ago by Vickie Lynch

In [13627]:

Refs #2379 Check that start row & column is not at end of panel

comment:54 Changed 9 years ago by Vickie Lynch

In [13685]:

Refs #2379 Check that InputWorkspace has OrientedLattice

comment:55 Changed 9 years ago by Vickie Lynch

In [13697]:

Refs #2379 Change category to Crystal

comment:56 Changed 9 years ago by Vickie Lynch

  • Status changed from accepted to verify
  • Resolution set to fixed

TOF IkeidaCarpenter integration works with fit of slices (IntegratePeakTimeSlices) or shoebox sum with pixels outside peak masked. Second pass to integrate small peaks will be a new ticket.

comment:57 Changed 9 years ago by Janik Zikovsky

  • Status changed from verify to verifying
  • Tester set to Janik Zikovsky

comment:58 Changed 9 years ago by Janik Zikovsky

  • Status changed from verifying to closed

Tried both methods with success.

comment:59 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 3226

Note: See TracTickets for help on using tickets.